Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting for initializing in a disabled state #12

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

rparrett
Copy link
Contributor

Fixes #10.

I was doing this in a local fork anyway to test an app, so I figured I might as well open a PR.

This does what is described in #10 (comment).

Side note: It's not totally clear to me why ParticleSpawnerData is not just included in ParticleSpawnerBundle. I experimented with removing it here: rparrett@d33aa0a and at a glance, things don't seem broken.

@mbrea-c
Copy link
Owner

mbrea-c commented Mar 27, 2024

LGTM, and examples run fine. Merging, thanks for the contribution!

Side note: It's not totally clear to me why ParticleSpawnerData is not just included in ParticleSpawnerBundle. I experimented with removing it here: rparrett@d33aa0a and at a glance, things don't seem broken.

If I remember correctly it used to be because I used scenes to build composite effects in an earlier build of my game, and before I made bevy_utilitarian I was using some types in ParticleSpawnerData that made it non-reflectable. Neither of these things apply anymore though, so it should be fine to put ParticleSpawnerData back in the bundle.

@mbrea-c mbrea-c merged commit a191fd8 into mbrea-c:master Mar 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow spawning particle systems with an initial disabled state
2 participants