Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated soundevent to 2.0 #16

Merged
merged 4 commits into from
May 17, 2024
Merged

Updated soundevent to 2.0 #16

merged 4 commits into from
May 17, 2024

Conversation

mbsantiago
Copy link
Owner

This PR enhances backend dependency management and expands the audio format compatibility of the whombat application.

Key Changes

  1. Backend Dependency Management: Transitioned the backend package manager from [previous tool] to Rye for improved dependency resolution and maintainability.
  2. Expanded Audio Format Support: Upgraded the soundevent package to version 2.0, unlocking support for FLAC and MP3 formats in addition to the existing WAV format. This significantly broadens the types of audio files whombat can process (Proposal: Adding Support for .flac Audio Files #1).

Additional Considerations

  • While initial testing with the new audio formats has been positive, further validation is required to ensure compatibility with all whombat features.

Next Steps

  • Conduct thorough testing of whombat functionality using various FLAC, MP3 and other supported audio files.
  • Address any issues identified during testing.
  • Update documentation to reflect the expanded range of supported audio formats.

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 59.88%. Comparing base (66aafa3) to head (9f97e85).
Report is 5 commits behind head on main.

Files Patch % Lines
back/src/whombat/api/recordings.py 50.00% 3 Missing ⚠️
back/src/whombat/api/audio.py 0.00% 2 Missing ⚠️
back/src/whombat/api/spectrograms.py 50.00% 1 Missing ⚠️
back/src/whombat/core/images.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   59.90%   59.88%   -0.02%     
==========================================
  Files         171      171              
  Lines        7626     7618       -8     
==========================================
- Hits         4568     4562       -6     
+ Misses       3058     3056       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mbsantiago mbsantiago merged commit f159925 into main May 17, 2024
2 of 4 checks passed
@mbsantiago mbsantiago deleted the feature/soundevent_update branch May 17, 2024 17:44
@mbsantiago mbsantiago restored the feature/soundevent_update branch May 23, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant