Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/remove splash #17

Merged
merged 2 commits into from
May 17, 2024
Merged

Fix/remove splash #17

merged 2 commits into from
May 17, 2024

Conversation

mbsantiago
Copy link
Owner

This PR removes the PyInstaller-generated splash screen from the application.

Motivation

The splash screen was causing several issues:

  • Crashes: It led to application crashes on macOS.
  • Lack of Functionality: We were unable to display meaningful information on the splash screen.
  • Visual Issues: The splash screen image appeared with a distorted border, leading to a poor user experience.

Given these issues, we decided that removing the splash screen was the best course of action.

Future Considerations

While we have removed the PyInstaller-generated splash screen, we may explore creating a custom splash screen implementation in the future. This would allow us to have more control over the splash screen's appearance and functionality, potentially providing a better user experience.

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.83%. Comparing base (f159925) to head (8b7c3a3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
- Coverage   59.88%   59.83%   -0.06%     
==========================================
  Files         171      171              
  Lines        7618     7603      -15     
==========================================
- Hits         4562     4549      -13     
+ Misses       3056     3054       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mbsantiago mbsantiago merged commit d89615c into main May 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant