-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/use envs for endpoint #40
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
[bumpversion] | ||
current_version = 0.6.4 | ||
current_version = 0.7.0 | ||
commit = True | ||
tag = True | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
v22.9.0 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
NEXT_PUBLIC_BACKEND_HOST=http://localhost:5000 |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
import createAPI from "@/lib/api"; | ||
|
||
const api = createAPI({ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
const baseURL =
process.env.NODE_ENV === "development"
? process.env.NEXT_PUBLIC_BACKEND_HOST || ""
: ""; This way the environment variable is used in development (when the backend and frontend are separated) but not in production (when the backend serves the frontend in the same domain). |
||
baseURL: "http://localhost:5000", | ||
baseURL: `${process.env.NEXT_PUBLIC_BACKEND_HOST}`, | ||
withCredentials: true, | ||
}); | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we are at it can you please add the
libsndfile1
library?back/Dockerfile
too?This other
Dockerfile
is for dev development but also needs these dependencies.