Fix filter, filter and unnecessary use of apply (#2106)

* fix filter, filter and unnecessary use of apply * arg isnt a list
mbta · Jun 24, 2024 · bc69125 · bc69125
1 parent aad62bb
commit bc69125
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/lib/alerts/historical_alert.ex b/lib/alerts/historical_alert.ex
@@ -49,7 +49,7 @@ defmodule Alerts.HistoricalAlert do
         :stop -> @stops_repo
       end
 
-    case apply(module, :get, [id]) do
+    case module.get(id) do
       %{name: name} when not is_nil(name) -> name
       _ -> id
     end

diff --git a/lib/predictions/stream.ex b/lib/predictions/stream.ex
@@ -82,8 +82,7 @@ defmodule Predictions.Stream do
 
   defp to_predictions(%JsonApi{data: data}) do
     data
-    |> Enum.filter(&(&1.type == "prediction"))
-    |> Enum.filter(&Repo.has_trip?/1)
+    |> Enum.filter(&(&1.type == "prediction" && Repo.has_trip?(&1)))
     |> Enum.map(&StreamParser.parse/1)
   end