Show diversion diagrams in diversion alerts #2067
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonyshull
commented
May 20, 2024
| @@ -0,0 +1,50 @@ | |||
| defmodule CMS.Page.DiversionsTest do | |||
There was a problem hiding this comment.
📓 This is really just a copy of the /page/basic_test.exs. For tests related to the CMS, we have to use the static JSON responses until we rewrite all of the CMS tests.
anthonyshull
commented
May 20, 2024
| @@ -11,6 +11,12 @@ defmodule PageTest do | |||
| describe "from_api/1" do | |||
| test "switches on the node type in the json response and returns the proper page struct" do | |||
| assert %Page.Basic{} = Page.from_api(Static.basic_page_response()) | |||
|
|
|||
| diversions_data = | |||
| Static.basic_page_response() |> Map.put("field_page_type", [%{"name" => "Diversions"}]) | |||
There was a problem hiding this comment.
📓 This is just a hacky way of creating a Diversions page without creating a giant JSON blob like all other CMS test pages.
anthonyshull
commented
May 20, 2024
| diversion = Factories.Alerts.Alert.build(:alert, effect: :shuttle) | ||
| non_diversion = Factories.Alerts.Alert.build(:alert, effect: :delay) | ||
|
|
||
| Store.update([diversion, non_diversion], nil) |
There was a problem hiding this comment.
📓 We have to use this store until we convert the CMS code to using Mox for this.
amaisano
approved these changes
May 21, 2024
thecristen
approved these changes
May 21, 2024
anthonyshull
force-pushed
the
ags/alerts-diversions
branch
2 times, most recently
from
763122d to
e4bc4b8
Compare
anthonyshull
force-pushed
the
ags/alerts-diversions
branch
from
afa9b7a to
db435f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.asana.com/0/555089885850811/1207209404321117/f