Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Credo): Reduce function nesting #2083

Merged
merged 4 commits into from
Jun 7, 2024
Merged

fix(Credo): Reduce function nesting #2083

merged 4 commits into from
Jun 7, 2024

Conversation

kotva006
Copy link
Contributor

@kotva006 kotva006 requested a review from a team as a code owner May 31, 2024 15:19
@kotva006 kotva006 requested a review from anthonyshull May 31, 2024 15:19
anthonyshull
anthonyshull requested changes May 31, 2024
View reviewed changes
lib/dotcom_web/controllers/schedule/line.ex Outdated Show resolved Hide resolved
lib/dotcom_web/controllers/schedule_controller.ex Outdated Show resolved Hide resolved
lib/dotcom_web/controllers/schedule_controller.ex Outdated Show resolved Hide resolved
lib/dotcom_web/controllers/trip_plan_controller.ex Outdated Show resolved Hide resolved
lib/dotcom_web/views/page_content_view.ex Outdated Show resolved Hide resolved
lib/mix/tasks/header_footer.ex Outdated Show resolved Hide resolved
lib/mix/tasks/header_footer.ex Outdated Show resolved Hide resolved
lib/mix/tasks/header_footer.ex Show resolved Hide resolved
@kotva006 kotva006 requested a review from anthonyshull June 5, 2024 16:03
anthonyshull
anthonyshull approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@anthonyshull anthonyshull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kotva006 kotva006 merged commit da46bff into main Jun 7, 2024
23 checks passed
@kotva006 kotva006 deleted the rk/credo-nesting branch June 7, 2024 14:27
thecristen pushed a commit that referenced this pull request Jun 24, 2024
@kotva006 @thecristen
fix(Credo): Reduce function nesting (#2083)
878a061 
* fix(Credo): Reduce function nesting

* Addressed feedback

* Changed to private def

* Added missing defp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonyshull anthonyshull anthonyshull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kotva006 @anthonyshull