storybook: Add storybook and stories for route symbols #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlarson
requested review from
anthonyshull and
thecristen
and removed request for
anthonyshull
thecristen
reviewed
Nov 18, 2024
| end | ||
|
|
||
| scope "/", DotcomWeb do | ||
| # pipe_through([:secure, :browser, :browser_live, :basic_auth]) |
There was a problem hiding this comment.
Did you mean to use this line?
There was a problem hiding this comment.
In any case just wanted to flag that this is not behind basic auth!
thecristen
reviewed
Nov 18, 2024
| config :esbuild, | ||
| version: "0.17.11", | ||
| default: [ | ||
| # args: ~w(js/app.js js/storybook.js --bundle --target=es2017 --outdir=../priv/static/assets), |
There was a problem hiding this comment.
Did you want to delete this?
thecristen
reviewed
Nov 19, 2024
| @@ -84,6 +85,7 @@ defmodule DotCom.Mixfile do | |||
| {:ecto, "3.12.4"}, | |||
| {:eflame, "1.0.1", only: :dev}, | |||
| {:ehmon, [github: "mbta/ehmon", only: :prod]}, | |||
| {:esbuild, "~> 0.8", runtime: Mix.env() == :dev}, | |||
There was a problem hiding this comment.
I'm curious if this effects whether the build works for prod?
thecristen
requested changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be accessed by going to http://localhost:4001/storybook, and using the same basic auth credentials that you use to access the admin page.