feat(TripPlanner): display backend error message #2243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlarson
reviewed
Dec 5, 2024
| assert str =~ assigns.title | ||
| assert str =~ assigns.content | ||
|
|
||
| assert rendered_to_string(~H""" |
There was a problem hiding this comment.
Nit (non-blocking): I think the assertion that would make this section justify its existence would be to somehow assert that there is no title.
joshlarson
approved these changes
Dec 5, 2024
to hopefully fix datepicker and possibly other input errors
thecristen
force-pushed
the
cbj/otp-errors
branch
from
8094a3e to
f2c07d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: Trip Planner returns error messages
Using the recent update from the OpenTripPlannerClient (which is now migrated to the MBTA Github org!), we can now show more detailed error messages in the trip planner. (from the Asana ticket, this is the section "New errors for OTP input errors")
Technically the "Unable to plan your trip" error is located in the wrong spot – it should be where the itineraries display. We can move that in a followup PR after @joshlarson refactors
TripPlannerResultsSectionfrom a LiveComponent into a function component as previously discussed.