Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove wheelchair icon from non-accessible stop pages #2244

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

joshlarson
Copy link
Contributor

Context

Slack Thread
Notion Doc

Before

Screenshot 2024-12-03 at 4 36 26 PM Screenshot 2024-12-03 at 4 36 33 PM

After

Screenshot 2024-12-03 at 4 34 57 PM Screenshot 2024-12-03 at 4 35 04 PM

@joshlarson joshlarson requested a review from a team as a code owner December 3, 2024 21:38
@joshlarson joshlarson enabled auto-merge (squash) December 3, 2024 21:39
@joshlarson joshlarson added the dev-blue Deploy to dev-blue label Dec 3, 2024
Copy link
Collaborator

@thecristen thecristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh huh, i shouldn't have changed that bit from last iteration! this should do the trick.

@@ -23,4 +23,14 @@ describe("AccessibilityIcon", () => {
);
expect(screen.getByTestId("empty")).not.toBeEmptyDOMElement();
});

it("should not return an icon for an accessible stop", () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this wording is pretty confusing!

@joshlarson joshlarson merged commit 929128f into main Dec 3, 2024
25 of 27 checks passed
@joshlarson joshlarson deleted the jdl/fix-wheelchair-icon-on-station-pages branch December 3, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-blue Deploy to dev-blue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants