Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui(TripPlanner): Fix margins, paddings, and borders for results panel #2276

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

joshlarson
Copy link
Contributor

@joshlarson joshlarson commented Dec 18, 2024

Screenshots

Before (Summary / Mobile)

Screenshot 2024-12-18 at 5 05 44 PM

After (Summary / Mobile)

Screenshot 2024-12-18 at 5 04 40 PM

Before (Summay / Desktop)

Screenshot 2024-12-18 at 5 05 28 PM

After (Summary / Desktop)

Screenshot 2024-12-18 at 5 04 50 PM

(Note: The fact that the route is drawn on the map is because of an unrelated bug and has to do with the order in which I took the screenshots, and has nothing to do with this PR)

Before (Detail / Mobile)

Screenshot 2024-12-18 at 5 06 20 PM

After (Detail / Mobile)

Screenshot 2024-12-18 at 5 04 02 PM

Before (Detail / Desktop)

Screenshot 2024-12-18 at 5 06 05 PM

After (Detail / Desktop)

Screenshot 2024-12-18 at 5 04 16 PM

Summary of changes

Asana Ticket: Fix margins, padding, and borders for the panel to the left of the map

Changes:

  • Removed border and margins around the results panel
  • Removed a border at the bottom of itinerary details
  • Replaced grid with flex as an implementation for arranging the results panel next to the map
  • Made the results panel grow to no more than 500px on desktop

General checks

  • Are the changes organized into self-contained commits with descriptive and well-formatted commit messages? This is a good practice that can facilitate easier reviews.
  • Testing. Do the changes include relevant passing updates to tests? This includes updating screenshots. Preferably tests are run locally to verify that there are no test failures created by these changes, before opening a PR.
  • Tech debt. Have you checked for tech debt you can address in the area you're working in? This can be a good time to address small issues, or create Asana tickets for larger issues.

New UI, or substantial UI changes

  • Cross-browser compatibility is less of an issue now that we're no longer supporting IE, but changes still need to work as expected in Safari, Chrome, and Firefox.
  • Are interactive elements accessible? This includes at minimum having relevant keyboard interactions and visible focus, but can also include verification with screen reader testing.
  • Other accessibility checks such as sufficient color constrast, or whether the layout holds up at 200% zoom level.

New endpoints, or non-trivial changes to current endpoints

  • Have we load-tested any new pages or internal API endpoints that will receive significant traffic? See load testing docs
  • If this change involves routes, does it work correctly with pertinent "unusual" routes such as the combined Green Line, Silver Line, Foxboro commuter rail, and single-direction bus routes like the 170?

@joshlarson joshlarson requested a review from a team as a code owner December 18, 2024 21:35
@class
]}>
<div
:if={Enum.count(@results.itinerary_groups) > 0 && @results.itinerary_group_selection}
class="h-min w-full p-4"
class="h-min w-full mb-3.5"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a 3.5?!?1

@thecristen thecristen merged commit cd4abee into main Dec 19, 2024
17 checks passed
@thecristen thecristen deleted the jdl/fix-margin-and-padding-for-results-panel branch December 19, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants