Fix new schedules being a blank page in IE11 #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecristen
reviewed
Jan 30, 2020
thecristen
reviewed
Jan 30, 2020
digitalcora
force-pushed
the
cfg-ie11-line-diagram
branch
from
28a674f to
7249ed8
Compare
thecristen
approved these changes
Jan 31, 2020
|
I'm looking into why this seems to break the javascript test suite -- so far it seems as though the few JS files that get used in some of our tests are not yet transpiled (but should already be transpiled in the test). |
Codecov Report
@@ Coverage Diff @@
## master #366 +/- ##
=========================================
Coverage ? 93.96%
=========================================
Files ? 356
Lines ? 5946
Branches ? 0
=========================================
Hits ? 5587
Misses ? 359
Partials ? 0 |
Co-authored-by: Cristen Blair Jones <cristenblair@gmail.com>
digitalcora
force-pushed
the
cfg-ie11-line-diagram
branch
from
106dd71 to
250bd61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Ticket: 🐞 New schedules page is blank in IE11
So as not to mess with our existing Webpack config at all, this creates a new config that explicitly compiles
react-asyncusing the same options. I've tested this using CBT and it allows IE11 to load the line diagram, though unfortunately the live data is still missing (and it's very unclear why).