Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAX EIRP is 13dBm (= 19.95mW < 20mW) in as923jp #662

Merged
merged 1 commit into from
Oct 10, 2021
Merged

MAX EIRP is 13dBm (= 19.95mW < 20mW) in as923jp #662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion project_config/lmic_project_config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#define CFG_us915 1
//#define CFG_au915 1
//#define CFG_as923 1
// #define LMIC_COUNTRY_CODE LMIC_COUNTRY_CODE_JP /* for as923-JP */
//#define CFG_as923jp 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

I don't understand this part of change. The code on line 6 is the correct way to handle this (and in fact lmic_confgi_preconditions.h expands the shorthand). We avoid #ifdef as much as possible in the code; the config system converts #ifdef to equivalent symbols that are always either 1 or 0.

//#define CFG_kr920 1
//#define CFG_in866 1
#define CFG_sx1276_radio 1
Expand Down
4 changes: 4 additions & 0 deletions src/lmic/lorabase_as923.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,11 @@ enum {
AS923_FREQ_MAX = 928000000
};
enum {
#if defined(CFG_as923jp)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, this line should be #if LMIC_COUNTRY_CODE == LMIC_COUNTRY_CODE_JP.

AS923_TX_EIRP_MAX_DBM = 13 // 13 dBm = 19.95mW < 20mW
#else
AS923_TX_EIRP_MAX_DBM = 16 // 16 dBm
#endif
};
enum { DR_PAGE_AS923 = 0x10 * (LMIC_REGION_as923 - 1) };

Expand Down