makes the request accepting a socks address as proxy

mcloonan · Jul 15, 2015 · f0cfd69 · f0cfd69
1 parent 9048e1e
commit f0cfd69
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/httpi/request.rb b/lib/httpi/request.rb
@@ -139,7 +139,7 @@ def cookie_store
 
     # Expects a +url+, validates its validity and returns a +URI+ object.
     def normalize_url!(url)
-      raise ArgumentError, "Invalid URL: #{url}" unless url.to_s =~ /^http/
+      raise ArgumentError, "Invalid URL: #{url}" unless url.to_s =~ /^http|socks/
       url.kind_of?(URI) ? url : URI(url)
     end
 

diff --git a/spec/httpi/request_spec.rb b/spec/httpi/request_spec.rb
@@ -108,6 +108,11 @@
       expect(request.proxy).to eq(URI("http://proxy.example.com"))
     end
 
+    it 'also accepts the socks URL to use as a String' do
+      request.proxy ="socks://socks.example.com"
+      expect(request.proxy).to eq(URI("socks://socks.example.com"))
+    end
+
     it "also accepts a URI object" do
       request.proxy = URI("http://proxy.example.com")
       expect(request.proxy).to eq(URI("http://proxy.example.com"))