Refresh dependencies and list of supported Node.js versions #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kibertoad
commented
May 3, 2024
kibertoad
commented
- Updates runtime dependencies to latest versions
- Adds recent Node.js runtimes to CI
- Updates TypeScript and related dependencies
- Bumps expected engine version to the minimum one included in CI
kibertoad
commented
May 3, 2024
package.json
Outdated
| @@ -30,7 +30,7 @@ | |||
| }, | |||
| "author": "Matteo Collina <hello@matteocollina.com>", | |||
| "engines": { | |||
| "node": ">=10" | |||
| "node": ">=14" | |||
There was a problem hiding this comment.
Since Node 10 and 12 is not included in CI, it's not really possible to guarantee that they are still supported.
kibertoad
commented
May 3, 2024
| @@ -30,7 +30,7 @@ | |||
| }, | |||
| "author": "Matteo Collina <hello@matteocollina.com>", | |||
| "engines": { | |||
| "node": ">=10" | |||
| "node": ">=16" | |||
There was a problem hiding this comment.
Two reasons for this change:
- CI already was not executed on 10 and 12 before this change
- Newer TypeScript linter doesn't work on Node < 16. If for whatever reason it is important to preserve compatibility with Node 14, I can separate CI runs for linting and tests, but 14 has been EOL for a while anyway.
kibertoad
changed the title
mcollina
approved these changes
May 3, 2024
|
@mcollina Of course! Can you give a list of repos? |
|
Lines 17 to 22 in 061c68a |
|
Will go over them this week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.