Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional access list in BlobTx unmarshaling #103

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Optional access list in BlobTx unmarshaling #103

merged 2 commits into from
Feb 9, 2023

Conversation

Inphi
Copy link
Collaborator

@Inphi Inphi commented Feb 8, 2023

This allows users and the internal ethapi to return blob transactions containing a nil access list.

@roberto-bayardo
Copy link
Collaborator

did you want to make the same change for blob versioned hashes?

@Inphi
Copy link
Collaborator Author

Inphi commented Feb 8, 2023

did you want to make the same change for blob versioned hashes?

it's not necessary. we
already don't assert that the blob versioned hashes are not nil.

@roberto-bayardo
Copy link
Collaborator

did you want to make the same change for blob versioned hashes?

it's not necessary. we already don't assert that the blob versioned hashes are not nil.

But if they are nil they will pass through as nil right? I was wondering if we should be forcing them to empty lists.

@Inphi
Copy link
Collaborator Author

Inphi commented Feb 8, 2023

I was thinking perhaps we should enforce non-nil blob versioned hashes. As it's more likely that if nil then an invalid API use. And with the new gnark-kzg, one can't even verify a blob transaction containing zero blobs (and thus zero versioned hashes). blob versioned hash, like the base fee, seems more like a salient attribute of blob transactions that should always be explicitly set and never be nil.

@roberto-bayardo
Copy link
Collaborator

I was thinking perhaps we should enforce non-nil blob versioned hashes. As it's more likely that if nil then an invalid API use. And with the new gnark-kzg, one can't even verify a blob transaction containing zero blobs (and thus zero versioned hashes). blob versioned hash, like the base fee, seems more like a salient attribute of blob transactions that should always be explicitly set and never be nil.

Sgtm

@Inphi Inphi merged commit 3584bf7 into eip-4844 Feb 9, 2023
@Inphi Inphi deleted the opt-al2 branch February 9, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants