Add --eip4844 devnet flag #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gonna merge now even though the bootnodes preconfiguration doesn't quite work as bootnodes are currently iffy on the devnet. |
protolambda
reviewed
Sep 17, 2022
| @@ -143,6 +143,8 @@ func remoteConsole(ctx *cli.Context) error { | |||
| path = filepath.Join(path, "sepolia") | |||
| } else if ctx.GlobalBool(utils.KilnFlag.Name) { | |||
| path = filepath.Join(path, "kiln") | |||
| } else if ctx.GlobalBool(utils.KilnFlag.Name) { | |||
There was a problem hiding this comment.
yeah, it's a bug. It should be the eip4844 flag
There was a problem hiding this comment.
though this has been fixed since on the eip-4844 branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configures the genesis and network parameters of the protodanksharding devnet,