Efficient Fiat-Shamir challenges using hashing #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By avoiding ssz merklelization, we significantly reduce the latency of generating FS challenges. Before: ``` BenchmarkVerifyMultiple/8-6 16 69890960 ns/op 25221325 B/op 399904 allocs/op BenchmarkVerifyMultiple/16-6 8 138506286 ns/op 50439658 B/op 799792 allocs/op ``` After: ``` BenchmarkVerifyMultiple/8-6 27 41349482 ns/op 22059083 B/op 301451 allocs/op BenchmarkVerifyMultiple/16-6 14 80868200 ns/op 44114668 B/op 602909 allocs/op ```
|
This is great! I assume this is not a backwards compatible change since the hash values presumably change? |
|
yup. This isnt backwards compatible |
|
OK, will try to implement in prysm soon then. |
|
|
||
| // sszHash returns the hash ot the raw serialized ssz-container (i.e. without merkelization) | ||
| func sszHash(c codec.Serializable) ([32]byte, error) { | ||
| sha := sha256.New() |
There was a problem hiding this comment.
why sha256 and not keccak/sha3? I guess it might be faster but possibly less future proof?
There was a problem hiding this comment.
No real reason other than to be consistent with how hashing is already done on the beacon chain. sha256 is the only hash being used on the beacon chain.
There was a problem hiding this comment.
Thanks, implementation consistency is certainly a good reason.
roberto-bayardo
approved these changes
Aug 22, 2022
|
Will merge once the spec has been updated for sha256 challenges. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By avoiding ssz merklelization, we significantly reduce the latency of generating FS
challenges.