fix panic issue when ExcessDataGas is nil #37
Conversation
roberto-bayardo
force-pushed
the
excess-data-gas-fix
branch
from
bf6679c
to
23b22a1
Compare
core/state_transition.go
Outdated
| if st.evm.ChainConfig().IsSharding(st.evm.Context.BlockNumber) { | ||
| if st.evm.Context.ExcessDataGas == nil { | ||
| // this edge-case will happen when the parent block is pre EIP-4844 | ||
| st.evm.Context.ExcessDataGas = new(big.Int) |
There was a problem hiding this comment.
seems awkward to update the State Context inside buyGas. Could we move this initialization elsewhere, perhaps when the context is created?
There was a problem hiding this comment.
I considered making it always non-nil in NewEVMBlockContext but wasn't sure if I should make the MaxFeePerDataGas field be handled differently than BaseFee, which is left as nil when unspecified. I can't really think of any reasons why checking for nil ExcessDataGas would be important/informative though so perhaps that is the best place for it.
There was a problem hiding this comment.
Updated to always set to non-nil in NewEVMBlockContext.
roberto-bayardo
force-pushed
the
excess-data-gas-fix
branch
2 times, most recently
from
2dfedc8
to
a0a36aa
Compare
core/evm.go
Outdated
| @@ -44,7 +44,7 @@ func NewEVMBlockContext(header *types.Header, excessDataGas *big.Int, chain Chai | |||
| beneficiary common.Address | |||
| baseFee *big.Int | |||
| random *common.Hash | |||
| edg *big.Int | |||
| edg *big.Int = new(big.Int) | |||
There was a problem hiding this comment.
Let's add a comment here explaining the edge case we're covering.
roberto-bayardo
force-pushed
the
excess-data-gas-fix
branch
from
a0a36aa
to
36e1168
Compare
This issue may arise when the current block is a Sharding-enabled block but the parent is not.