Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge with master #57

Merged
merged 239 commits into from
Nov 24, 2022
Merged

Merge with master #57

merged 239 commits into from
Nov 24, 2022

Conversation

roberto-bayardo
Copy link
Collaborator

pulling in the latest upstream changes

gballet and others added 30 commits August 18, 2022 13:28
…5547)

typ will be nil when lookupStructType returns an error. cfg.Type should be used instead.
This avoids copying the input []byte while decoding trie nodes. In most
cases, particularly when the input slice is provided by the underlying
database, this optimization is safe to use.

For cases where the origin of the input slice is unclear, the copying version
is retained. The new code performs better even when the input must be
copied, because it is now only copied once in decodeNode.
* Fix some typos

* Fix some mistakes

* Revert 4byte.json

* Fix an incorrect fix

* Change files to fails
Unlock peerSet if there's an error in the downloader
* consensus/beacon: check ttd reached on pos blocks

* consensus/beacon: check ttd reached on pos blocks

* consensus/beacon: check ttd reached on pos blocks
This adds a cache for block logs which is shared by all filters. The cache
size of is configurable using the `--cache.blocklogs` flag.

Co-authored-by: Felix Lange <fjl@twurst.com>
* accounts/abi: fix set function

* don't break things

* update test
…reum#25524)

* eth/fetcher: introduce some lag in tx fetching

* eth/fetcher: change conditions a bit

* eth/fetcher: use per-batch quota check

* eth/fetcher: fix some comments

* eth/fetcher: address review concerns

* eth/fetcher: fix panic + add warn log

* eth/fetcher: fix log

* eth/fetcher: fix log

* cmd/devp2p/internal/ethtest: fix ignorign tx announcements from prev. tests

* cmd/devp2p/internal/ethtest: fix TestLargeTxRequest

This increases the number of tx relay messages the test waits for. Since
go-ethereum now processes incoming txs in smaller batches, the
announcement messages it sends are also smaller.

Co-authored-by: Felix Lange <fjl@twurst.com>
…on" (ethereum#25567)

Revert "eth/fetcher: don't spend too much time on transaction inclusion (ethereum#25524)"

This reverts commit 0ce494b.
…thereum#25569)

* eth/catalyst: warn less frequently if no beacon client is available

* eth/catalyst: tweak warning frequency a bit

* eth/catalyst: some more tweaks

* Update api.go

Co-authored-by: Felix Lange <fjl@twurst.com>
ethereum#25578)

* eth/downloader: handle junkbodies/receipts in the beacon sync

* core: check for header presence when checking for blocks
core/state, trie: fix trie flush order for proper pruning
consensus/beacon: don't ignore errors
Some small fixes to get the existing debug methods to conform to the spec. Mainly dropping the encoding information from the method name as it should be deduced from the debug context and allowing the method to be invoked by either block number or block hash. It also adds the method debug_getTransaction which returns the raw tx bytes by tx hash. This is pretty much equivalent to the eth_getRawTransactionByHash method.
…um#25504)


Co-authored-by: Felix Lange <fjl@twurst.com>
Co-authored-by: rjl493456442 <garyrong0905@gmail.com>
Signed-off-by: Abirdcfly <fp544037857@gmail.com>

Signed-off-by: Abirdcfly <fp544037857@gmail.com>
Jolly23 and others added 13 commits November 14, 2022 15:16
It seems there is no fully typed library implementation of an LRU cache.
So I wrote one. Method names are the same as github.com/hashicorp/golang-lru,
and the new type can be used as a drop-in replacement.

Two reasons to do this:

- It's much easier to understand what a cache is for when the types are right there.
- Performance: the new implementation is slightly faster and performs zero memory
   allocations in Add when the cache is at capacity. Overall, memory usage of the cache
   is much reduced because keys are values are no longer wrapped in interface.
rpc: fix connection tracking in Server

When upgrading to mapset/v2 with generics, the set element type used in
rpc.Server had to be changed to *ServerCodec because ServerCodec is not
'comparable'. While the distinction is technically correct, we know all
possible ServerCodec types, and all of them are comparable. So just use
a map instead.
Implements TSTORE and TLOAD as specified by the following EIP:

https://eips.ethereum.org/EIPS/eip-1153
https://ethereum-magicians.org/t/eip-1153-transient-storage-opcodes/553


Co-authored-by: Sara Reynolds <snreynolds2506@gmail.com>
Co-authored-by: Martin Holst Swende <martin@swende.se>
Co-authored-by: Gary Rong <garyrong0905@gmail.com>
This adds a way to specify HTTP headers per request.

Co-authored-by: Martin Holst Swende <martin@swende.se>
Co-authored-by: Felix Lange <fjl@twurst.com>
Use noopTracer as a base for other native tracers to avoid extra boilerplate for unimplemented hooks.
This PR improves and extends the tests a bit
This removes an RPC test which takes > 90s to execute, and updates the
internal/guide tests to use lighter scrypt parameters.

Co-authored-by: Felix Lange <fjl@twurst.com>
This prevents DoS when connected to a malicious ethstats server.
@roberto-bayardo roberto-bayardo changed the base branch from master to eip-4844 November 20, 2022 19:26
@roberto-bayardo
Copy link
Collaborator Author

@Inphi in case you missed this one

@Inphi
Copy link
Collaborator

Inphi commented Nov 24, 2022

There are more commits in here than expected. Didn't we already merge #43 to the eip-4844 branch?

@roberto-bayardo
Copy link
Collaborator Author

There are more commits in here than expected. Didn't we already merge #43 to the eip-4844 branch?

yeah we did, wonder what I did wrong here. I started with eip-4844 branch, merged master into it, then have been doing a few more git merges against both eip-4844 and master in order to keep it up to date. Git is still a bit of a mystery to me!

@Inphi
Copy link
Collaborator

Inphi commented Nov 24, 2022

Oh I see what happened. The earlier merge-with-master merge PR was squashed into a single commit. Since we lost all individual commits, git couldn't tell if a merge had already taken place.

For this PR let's retain the commits as a "Merge pull request" so the diff on future merges is minimal.

Copy link
Collaborator

@Inphi Inphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for being patient :-)

@roberto-bayardo
Copy link
Collaborator Author

Oh I see what happened. The earlier merge-with-master merge PR was squashed into a single commit. Since we lost all individual commits, git couldn't tell if a merge had already taken place.

For this PR let's retain the commits as a "Merge pull request" so the diff on future merges is minimal.

Ahah makes sense so one should never squash merge PRs. That would have made the next merge task a lot simpler too huh?

@roberto-bayardo roberto-bayardo merged commit c7541cd into eip-4844 Nov 24, 2022
@roberto-bayardo roberto-bayardo deleted the merge-with-master branch November 24, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.