This repository has been archived by the owner on Oct 27, 2021. It is now read-only.
forked from nsf/gocode
-
Notifications
You must be signed in to change notification settings - Fork 87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WORK IN PROGRESS This doesn't support -source or gb build layouts.
WORK IN PROGRESS This doesn't support -source or gb build layouts.
ianthehat
approved these changes
Oct 16, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable.
This was referenced Oct 16, 2018
@stamblerre This is independent of the |
@ramya-rao-a, yeah this is just an improvement to gocode. The |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the caching branch into master. The cache branch reads export data files and caches them. If no export data is available, the cache importer falls back to the source importer, and it caches its results for a certain limited amount of time (20 minutes now, can be changed). The cache importer works with packages in a gb layout. If the
-source
flag is specified, the original gbimporter with the underlying source importer is used. Future work would involve merging these two importers, as there is a bit of duplicated code here.