Skip to content

Commit

Permalink
fix(deps): pin Node.js to v18.17 + use .nvmrc from interactive-exampl…
Browse files Browse the repository at this point in the history
…es (#1625)

* chore(workflows): use node-version-file

* fix(deps): pin Node.js to v18.17

Our tests fail with later minor versions.

* fix(workflows): use .nvmrc from interactive-examples
  • Loading branch information
caugner authored Dec 21, 2023
1 parent 872f31f commit 968ae6f
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
18 changes: 9 additions & 9 deletions .github/workflows/npm-published-simulation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,26 +14,26 @@ jobs:
runs-on: ubuntu-latest

steps:
- name: Setup Node.js environment (interactive-examples)
uses: actions/setup-node@v4
with:
node-version: 18

- name: Checkout mdn/interactive-examples
uses: actions/checkout@v4
with:
repository: mdn/interactive-examples
path: interactive-examples

- name: Install all packages (interactive-examples)
working-directory: interactive-examples
run: npm ci

- name: Checkout this repository
uses: actions/checkout@v4
with:
path: bob

- name: Setup Node.js environment (interactive-examples)
uses: actions/setup-node@v4
with:
node-version-file: "interactive-examples/.nvmrc"

- name: Install all packages (interactive-examples)
working-directory: interactive-examples
run: npm ci

- name: Install all packages (bob)
working-directory: bob
run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
node-version-file: ".nvmrc"
- name: Install dependencies
run: npm ci
- name: Prepack
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v18
v18.17

0 comments on commit 968ae6f

Please sign in to comment.