Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): allow setting defaultTab in tabbed examples #758

Merged
merged 5 commits into from
Apr 27, 2022

Conversation

NiedziolkaMichal
Copy link
Member

This code adds support for "defaultTab" property in css examples of type "tabbed". That property may have values "html", "css" or "js" and will set default tab that will be open on page load. It will be usefull in interactive example of @keyframes, that may be added in PR #2094.

Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two nits about code style (for consistency), and a more important comment about WebAssembly examples.

editor/js/editor.js Outdated Show resolved Hide resolved
editor/js/editor.js Outdated Show resolved Hide resolved
editor/js/editor.js Outdated Show resolved Hide resolved
NiedziolkaMichal and others added 4 commits April 25, 2022 16:14
Co-authored-by: Claas Augner <github@caugner.de>
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@caugner caugner changed the title defaultTab in tabbed examples feat(editor): allow setting defaultTab in tabbed examples Apr 27, 2022
@caugner caugner merged commit 7bc449d into mdn:main Apr 27, 2022
@NiedziolkaMichal
Copy link
Member Author

@caugner Thank you for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Contributions by the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants