-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): allow setting defaultTab in tabbed examples #758
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just two nits about code style (for consistency), and a more important comment about WebAssembly examples.
This reverts commit fa81ef4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@caugner Thank you for review. |
This code adds support for "defaultTab" property in css examples of type "tabbed". That property may have values "html", "css" or "js" and will set default tab that will be open on page load. It will be usefull in interactive example of @keyframes, that may be added in PR #2094.