-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimum top margin in tabbed examples #820
Conversation
I personally think that a simple Would you be down for that? |
This pull request has merge conflicts that must be resolved before it can be merged. |
@queengooborg I have checked examples and indeed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, LGTM!
* Tabbed examples use IFrame instead of Shadow DOM * Applied padding change from #820
This PR is a fix for #743 and #817.
Problem is that Output Label partically hides the content of examples that don't have "margin-top" property set, on the first element present in example.
When first element is label, table, img or any other element without margin-top, example looks like this:
When margin-top is set, like in element p, example looks fine:
I discussed with wbamberg in #743 to add padding-top to "output", which would move downwards every example, or to remove label altogether. Today I thought to add:
at the very top of "output" element and to create following rule:
This would take advantage of margin collapsing, so
p
examples would looks exactly the same as they are now, while examples without margin on the top would be moved a bit lower. In this PR I have changed 10px(default margin to p) to 13px, because examples look better that way: