Skip to content

Commit

Permalink
feat(browsers): Add pref_url for feature flags page (#3407)
Browse files Browse the repository at this point in the history
  • Loading branch information
ExE-Boss authored and Elchi3 committed Feb 13, 2019
1 parent 78fff5d commit 1482169
Show file tree
Hide file tree
Showing 8 changed files with 16 additions and 1 deletion.
1 change: 1 addition & 0 deletions browsers/chrome.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"browsers": {
"chrome": {
"name": "Chrome",
"pref_url": "chrome://flags",
"releases": {
"1": {
"release_date": "2008-12-11",
Expand Down
1 change: 1 addition & 0 deletions browsers/chrome_android.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"browsers": {
"chrome_android": {
"name": "Chrome Android",
"pref_url": "chrome://flags",
"releases": {
"18": {
"release_date": "2012-06-27",
Expand Down
1 change: 1 addition & 0 deletions browsers/edge.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"browsers": {
"edge": {
"name": "Edge",
"pref_url": "about:flags",
"releases": {
"12": {
"release_date": "2015-07-28",
Expand Down
1 change: 1 addition & 0 deletions browsers/edge_mobile.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"browsers": {
"edge_mobile": {
"name": "Edge Mobile",
"pref_url": "about:flags",
"releases": {
"12": {
"release_date": "2015-07-15",
Expand Down
1 change: 1 addition & 0 deletions browsers/firefox.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"browsers": {
"firefox": {
"name": "Firefox",
"pref_url": "about:config",
"releases": {
"1": {
"release_date": "2004-11-09",
Expand Down
1 change: 1 addition & 0 deletions browsers/firefox_android.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"browsers": {
"firefox_android": {
"name": "Firefox Android",
"pref_url": "about:config",
"releases": {
"4": {
"release_date": "2011-03-29",
Expand Down
7 changes: 6 additions & 1 deletion schemas/browsers-schema.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ The file `firefox.json` is structured like this:
"browsers": {
"firefox": {
"name": "Firefox",
"pref_url": "about:config",
"releases": {
"1.5": {
"release_date": "2005-11-29",
Expand All @@ -35,7 +36,11 @@ Underneath, there is a `releases` object which will hold the various releases of

### `name`

The `name` string is an optional property which should use the browser brand name and avoid English words if possible, for example `"Firefox"`, `"Firefox Android"`, `"Safari"`, `"iOS Safari"`, etc.
The `name` string is a required property which should use the browser brand name and avoid English words if possible, for example `"Firefox"`, `"Firefox Android"`, `"Safari"`, `"iOS Safari"`, etc.

### `pref_url`

An optional string containing the URL of the page where feature flags can be changed (e.g. `"about:config"` for Firefox or `"chrome://flags"` for Chrome).

### Release objects
The release objects consist of the following properties:
Expand Down
4 changes: 4 additions & 0 deletions schemas/browsers.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@
"type": "string",
"description": "Browser name, avoid using unnecessary English (e.g. prefer 'Chrome Android' over 'Chrome for Android')."
},
"pref_url": {
"type": "string",
"description": "URL of the page where feature flags can be changed (e.g. 'about:config' or 'chrome://flags')."
},
"releases": {
"type": "object",
"additionalProperties": { "$ref": "#/definitions/release_statement" }
Expand Down

0 comments on commit 1482169

Please sign in to comment.