Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api.Document.contains entry not needed #6832

Closed
foolip opened this issue Oct 5, 2020 · 4 comments · Fixed by #6850
Closed

api.Document.contains entry not needed #6832

foolip opened this issue Oct 5, 2020 · 4 comments · Fixed by #6850
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Comments

@foolip
Copy link
Contributor

foolip commented Oct 5, 2020

https://developer.mozilla.org/en-US/docs/Web/API/Node/contains also exists, and Document inherits from Node.

https://developer.mozilla.org/en-US/docs/Web/API/Document#Internet_Explorer_notes hints at the origin of this, but if IE had contains() on Document but not on Node, then that could be documented with a node for api.Node.contains.
@foolip foolip added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 5, 2020
This was referenced Oct 5, 2020
Merged
Closed
@foolip
Copy link
Contributor Author

foolip commented Oct 6, 2020

As pointed out in #6841, https://developer.mozilla.org/en-US/docs/Web/API/Document/contains is 404. https://developer.mozilla.org/en-US/docs/Web/API/Document#Internet_Explorer_notes should still be updated, though.

@foolip
Copy link
Contributor Author

foolip commented Oct 6, 2020

I wrote http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=8549 as a test case. It looks like in IE11, contains is actually on HTMLElement.prototype. We could add that in a note. The api.Document.contains entry and the bit in https://developer.mozilla.org/en-US/docs/Web/API/Document#Internet_Explorer_notes makes even less sense given that, however.

@foolip
Copy link
Contributor Author

foolip commented Oct 6, 2020

I've now removed the bit about contains from https://developer.mozilla.org/en-US/docs/Web/API/Document#Internet_Explorer_notes.

foolip added a commit to foolip/browser-compat-data that referenced this issue Oct 6, 2020
@foolip
Remove api.Document.contains and clarify IE support is just HTMLElement
25f9226 
Fixes mdn#6832.
@foolip foolip mentioned this issue Oct 6, 2020
Merged
@foolip
Copy link
Contributor Author

foolip commented Oct 6, 2020

I've sent #6832 to sort this out.

sideshowbarker pushed a commit that referenced this issue Oct 7, 2020
@foolip
Remove api.Document.contains and clarify IE support is just HTMLEleme…
b3cc680 
…nt (#6850)

Fixes #6832.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove api.Document.contains and clarify IE support is just HTMLElement foolip/browser-compat-data
1 participant
@foolip