Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove never-supported HTML*Element APIs #6931

Merged
merged 1 commit into from
Nov 6, 2020
Merged

Remove never-supported HTML*Element APIs #6931

merged 1 commit into from
Nov 6, 2020

Conversation

saschanaz
Copy link
Contributor

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any: Remove items that has never been supported #6854, Remove totally unimplemented things #6768

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 15, 2020
@foolip foolip mentioned this pull request Oct 29, 2020
Merged
foolip
foolip reviewed Nov 4, 2020
View reviewed changes
Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't finished reviewing yet, submitting half a review.

api/HTMLButtonElement.json
@@ -529,54 +529,6 @@
}
}
},
"menu": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLButtonElement/menu",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a 404. This entry came from wiki migration in #1132. I can't figure out what this ever was, but am pretty sure we should drop it from BCD.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My investigation says whatwg/html#2342 removed it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging that up! Sounds like it was only ever shipped in Gecko, and it was removed here:
mozilla/gecko-dev@6ca8672

api/HTMLIFrameElement.json
@@ -1012,55 +1012,6 @@
}
}
},
"setNfcFocus": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This came from #2877. As a Firefox API for internal use only, we can remove it.

api/HTMLIsIndexElement.json
@@ -1,148 +0,0 @@
{
"api": {
"HTMLIsIndexElement": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be paired with removal of https://github.com/mdn/browser-compat-data/blob/master/html/elements/isindex.json.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/isindex says "All major browsers have now removed <isindex>" but not when.

Per whatwg/html#1095 support was removed from Edge and Chrome back then, and Firefox was planning to remove. That happened here:
mozilla/gecko-dev@217ac88

WebKit support was dropped here:
https://trac.webkit.org/changeset/205858/webkit

So yes, this is far enough in the past that we can drop it from MDN/BCD.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's covered in #6955 but I can also do it here. Do you prefer to do it here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, let's leave it in the other PR, I didn't know it was covered there.

@foolip foolip mentioned this pull request Nov 5, 2020
Merged
5 tasks
foolip
foolip approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over to @chrisdavidmills, https://developer.mozilla.org/en-US/docs/Web/API/HTMLIsIndexElement needs to be removed.

api/HTMLIFrameElement.json
@@ -1012,55 +1012,6 @@
}
}
},
"setNfcFocus": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLIFrameElement/setNfcFocus",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have redirected https://developer.mozilla.org/en-US/docs/Web/API/HTMLIFrameElement/setNfcFocus to https://developer.mozilla.org/en-US/docs/Web/API/HTMLIFrameElement.

api/HTMLMenuItemElement.json
@@ -95,54 +95,6 @@
}
}
},
"command": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLMenuItemElement/command",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 404, no action needed.

api/HTMLTableElement.json
@@ -805,90 +805,6 @@
}
}
},
"sortable": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLTableElement/sortable",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 404

api/HTMLTableElement.json
},
"stopSorting": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLTableElement/stopSorting",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 404.

api/HTMLIsIndexElement.json
},
"prompt": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLIsIndexElement/prompt",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

404

api/HTMLIsIndexElement.json
},
"form": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLIsIndexElement/form",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

404

api/HTMLIsIndexElement.json
"api": {
"HTMLIsIndexElement": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLIsIndexElement",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://developer.mozilla.org/docs/Web/API/HTMLIsIndexElement will need to be removed.

@chrisdavidmills
Copy link
Contributor

@foolip https://wiki.developer.mozilla.org/en-US/docs/Web/API/HTMLIsIndexElement has been deleted.

foolip
foolip approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chrisdavidmills! I'll go ahead and merge this now.

@foolip foolip merged commit 63dbffd into mdn:master Nov 6, 2020
@saschanaz saschanaz deleted the nosupport-html branch November 6, 2020 11:47
@Elchi3 Elchi3 mentioned this pull request May 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip approved these changes

Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saschanaz @chrisdavidmills @foolip