Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove <isindex> and <input name=isindex> #1095

Merged
merged 1 commit into from
Apr 22, 2016
Merged

Remove <isindex> and <input name=isindex> #1095

merged 1 commit into from
Apr 22, 2016

Conversation

annevk
Copy link
Member

@annevk annevk commented Apr 22, 2016

Fixes #1088. Edge and Chrome have removed parser support. Chrome has
removed name=isindex support. And Firefox plans on removing support.

Fixes #1088. Edge and Chrome have removed parser support. Chrome has
removed name=isindex support. And Firefox plans on removing support.
@annevk
Copy link
Member Author

annevk commented Apr 22, 2016

The eventual commit message should probably also mention that <isindex> is an XSS concern due to bad filters. That's one of the reasons it was removed for from browsers.

@domenic
Copy link
Member

domenic commented Apr 22, 2016

LGTM

@annevk annevk merged commit 5c44abc into master Apr 22, 2016
@annevk annevk deleted the isindex branch April 22, 2016 16:37
@domenic domenic added the removal/deprecation Removing or deprecating a feature label Apr 22, 2016
zcorpan added a commit to html5lib/html5lib-tests that referenced this pull request Apr 22, 2016
iabudiab added a commit to iabudiab/HTMLKit that referenced this pull request May 18, 2016
Everybody else is doing it, so why can't we?
See: whatwg/html#1095

<isindex> is not only deprecated, it is completely removed from the spec
html5lib-tests: f99e2cb1851de9674519a220a1ccb3174b8cb846
@domenic domenic mentioned this pull request Jun 9, 2016
sideshowbarker added a commit to validator/validator that referenced this pull request Jul 27, 2016
tripu pushed a commit to tripu/validator that referenced this pull request Aug 19, 2016
craigbarnes added a commit to craigbarnes/lua-gumbo that referenced this pull request May 10, 2018
It was removed from the whatwg HTML spec more than 2 years ago and has
since been removed from most major browsers and also the html5lib tests.

See also:

* whatwg/html#1095
* html5lib/html5lib-tests#74

This commit makes 5 additional tree-construction tests pass:

    Ran 1646 tests in 0.15s
    Passed: 1646
    Failed: 0
    Skipped: 51
stevecheckoway pushed a commit to stevecheckoway/nokogumbo that referenced this pull request Aug 19, 2018
It was removed from the whatwg HTML spec more than 2 years ago and has
since been removed from most major browsers and also the html5lib tests.

See also:

* whatwg/html#1095
* html5lib/html5lib-tests#74

This commit makes 5 additional tree-construction tests pass:

    Ran 1646 tests in 0.15s
    Passed: 1646
    Failed: 0
    Skipped: 51
stevecheckoway pushed a commit to stevecheckoway/nokogumbo that referenced this pull request Aug 20, 2018
It was removed from the whatwg HTML spec more than 2 years ago and has
since been removed from most major browsers and also the html5lib tests.

See also:

* whatwg/html#1095
* html5lib/html5lib-tests#74

This commit makes 5 additional tree-construction tests pass:

    Ran 1646 tests in 0.15s
    Passed: 1646
    Failed: 0
    Skipped: 51
stevecheckoway pushed a commit to rubys/nokogumbo that referenced this pull request Aug 22, 2018
It was removed from the whatwg HTML spec more than 2 years ago and has
since been removed from most major browsers and also the html5lib tests.

See also:

* whatwg/html#1095
* html5lib/html5lib-tests#74

This commit makes 5 additional tree-construction tests pass:

    Ran 1646 tests in 0.15s
    Passed: 1646
    Failed: 0
    Skipped: 51
stevecheckoway pushed a commit to rubys/nokogumbo that referenced this pull request Aug 22, 2018
It was removed from the whatwg HTML spec more than 2 years ago and has
since been removed from most major browsers and also the html5lib tests.

See also:

* whatwg/html#1095
* html5lib/html5lib-tests#74

This commit makes 5 additional tree-construction tests pass:

    Ran 1646 tests in 0.15s
    Passed: 1646
    Failed: 0
    Skipped: 51
chozekun pushed a commit to chozekun/gumbo-parser that referenced this pull request Dec 13, 2018
It was removed from the whatwg HTML spec more than 2 years ago and has
since been removed from most major browsers and also the html5lib tests.

See also:

* whatwg/html#1095
* html5lib/html5lib-tests#74

This commit makes 5 additional tree-construction tests pass:

    Ran 1646 tests in 0.15s
    Passed: 1646
    Failed: 0
    Skipped: 51
chozekun pushed a commit to chozekun/gumbo-parser that referenced this pull request Dec 16, 2018
It was removed from the whatwg HTML spec more than 2 years ago and has
since been removed from most major browsers and also the html5lib tests.

See also:

* whatwg/html#1095
* html5lib/html5lib-tests#74

This commit makes 5 additional tree-construction tests pass:

    Ran 1646 tests in 0.15s
    Passed: 1646
    Failed: 0
    Skipped: 51
chozekun pushed a commit to chozekun/gumbo-parser that referenced this pull request Dec 16, 2018
It was removed from the whatwg HTML spec more than 2 years ago and has
since been removed from most major browsers and also the html5lib tests.

See also:

* whatwg/html#1095
* html5lib/html5lib-tests#74

This commit makes 5 additional tree-construction tests pass:

    Ran 1646 tests in 0.15s
    Passed: 1646
    Failed: 0
    Skipped: 51
flavorjones pushed a commit to sparklemotion/nokogiri that referenced this pull request Apr 7, 2021
It was removed from the whatwg HTML spec more than 2 years ago and has
since been removed from most major browsers and also the html5lib tests.

See also:

* whatwg/html#1095
* html5lib/html5lib-tests#74

This commit makes 5 additional tree-construction tests pass:

    Ran 1646 tests in 0.15s
    Passed: 1646
    Failed: 0
    Skipped: 51
flavorjones pushed a commit to sparklemotion/nokogiri that referenced this pull request Apr 7, 2021
It was removed from the whatwg HTML spec more than 2 years ago and has
since been removed from most major browsers and also the html5lib tests.

See also:

* whatwg/html#1095
* html5lib/html5lib-tests#74

This commit makes 5 additional tree-construction tests pass:

    Ran 1646 tests in 0.15s
    Passed: 1646
    Failed: 0
    Skipped: 51
wooorm pushed a commit to wooorm/html-void-elements that referenced this pull request May 19, 2023
Some obsolete elements got their void status takes away,
meaning `document.createElement(x).outerHTML` generates an opening and
closing tag, so this fix matches that behavior.

Related-to: whatwg/html#1095
Related-to: whatwg/html#2319

Closes GH-6.
Closes GH-7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
removal/deprecation Removing or deprecating a feature
Development

Successfully merging this pull request may close these issues.

2 participants