Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove <isindex> and <input name=isindex> #1095

Merged
merged 1 commit into from
Apr 22, 2016
Merged

Remove <isindex> and <input name=isindex> #1095

merged 1 commit into from
Apr 22, 2016

Conversation

annevk
Copy link
Member

@annevk annevk commented Apr 22, 2016

Fixes #1088. Edge and Chrome have removed parser support. Chrome has
removed name=isindex support. And Firefox plans on removing support.

@annevk
Remove <isindex> and <input name=isindex>
8721d92 
Fixes #1088. Edge and Chrome have removed parser support. Chrome has
removed name=isindex support. And Firefox plans on removing support.
@annevk
Copy link
Member Author

annevk commented Apr 22, 2016

The eventual commit message should probably also mention that <isindex> is an XSS concern due to bad filters. That's one of the reasons it was removed for from browsers.

@annevk annevk mentioned this pull request Apr 22, 2016
Closed
@domenic
Copy link
Member

domenic commented Apr 22, 2016

LGTM

@annevk annevk merged commit 5c44abc into master Apr 22, 2016
@annevk annevk deleted the isindex branch April 22, 2016 16:37
@zcorpan zcorpan mentioned this pull request Apr 22, 2016
Closed
@domenic domenic added the removal/deprecation Removing or deprecating a feature label Apr 22, 2016
zcorpan added a commit to html5lib/html5lib-tests that referenced this pull request Apr 22, 2016
@zcorpan
Update tests for <isindex> removal from the spec
f99e2cb 
Ref. whatwg/html#1095
@zcorpan zcorpan mentioned this pull request Apr 22, 2016
Merged
iabudiab added a commit to iabudiab/HTMLKit that referenced this pull request May 18, 2016
@iabudiab
Remove handling for <isindex> and <input name=isindex>
a01f1c1 
Everybody else is doing it, so why can't we?
See: whatwg/html#1095

<isindex> is not only deprecated, it is completely removed from the spec
html5lib-tests: f99e2cb1851de9674519a220a1ccb3174b8cb846
@domenic domenic mentioned this pull request Jun 9, 2016
Merged
sideshowbarker added a commit to validator/validator that referenced this pull request Jul 27, 2016
@sideshowbarker
Make <input name=isindex> an error
45a30ba 
See whatwg/html#1104 and whatwg/html#1095
tripu pushed a commit to tripu/validator that referenced this pull request Aug 19, 2016
@sideshowbarker @tripu
Make <input name=isindex> an error
b364d5e 
See whatwg/html#1104 and whatwg/html#1095
@patrickdark patrickdark mentioned this pull request Dec 4, 2017
Closed
craigbarnes added a commit to craigbarnes/lua-gumbo that referenced this pull request May 10, 2018
@craigbarnes
Remove special handling for <isindex> tag
7bd5162 
It was removed from the whatwg HTML spec more than 2 years ago and has
since been removed from most major browsers and also the html5lib tests.

See also:

* whatwg/html#1095
* html5lib/html5lib-tests#74

This commit makes 5 additional tree-construction tests pass:

    Ran 1646 tests in 0.15s
    Passed: 1646
    Failed: 0
    Skipped: 51
stevecheckoway pushed a commit to stevecheckoway/nokogumbo that referenced this pull request Aug 19, 2018
@craigbarnes @stevecheckoway
Remove special handling for <isindex> tag
67348ca 
It was removed from the whatwg HTML spec more than 2 years ago and has
since been removed from most major browsers and also the html5lib tests.

See also:

* whatwg/html#1095
* html5lib/html5lib-tests#74

This commit makes 5 additional tree-construction tests pass:

    Ran 1646 tests in 0.15s
    Passed: 1646
    Failed: 0
    Skipped: 51
stevecheckoway pushed a commit to stevecheckoway/nokogumbo that referenced this pull request Aug 20, 2018
@craigbarnes @stevecheckoway
Remove special handling for <isindex> tag
39fd595 
It was removed from the whatwg HTML spec more than 2 years ago and has
since been removed from most major browsers and also the html5lib tests.

See also:

* whatwg/html#1095
* html5lib/html5lib-tests#74

This commit makes 5 additional tree-construction tests pass:

    Ran 1646 tests in 0.15s
    Passed: 1646
    Failed: 0
    Skipped: 51
stevecheckoway pushed a commit to rubys/nokogumbo that referenced this pull request Aug 22, 2018
@craigbarnes @stevecheckoway
Remove special handling for <isindex> tag
aaa2ecb 
It was removed from the whatwg HTML spec more than 2 years ago and has
since been removed from most major browsers and also the html5lib tests.

See also:

* whatwg/html#1095
* html5lib/html5lib-tests#74

This commit makes 5 additional tree-construction tests pass:

    Ran 1646 tests in 0.15s
    Passed: 1646
    Failed: 0
    Skipped: 51
stevecheckoway pushed a commit to rubys/nokogumbo that referenced this pull request Aug 22, 2018
@craigbarnes @stevecheckoway
Remove special handling for <isindex> tag
2a01338 
It was removed from the whatwg HTML spec more than 2 years ago and has
since been removed from most major browsers and also the html5lib tests.

See also:

* whatwg/html#1095
* html5lib/html5lib-tests#74

This commit makes 5 additional tree-construction tests pass:

    Ran 1646 tests in 0.15s
    Passed: 1646
    Failed: 0
    Skipped: 51
chozekun pushed a commit to chozekun/gumbo-parser that referenced this pull request Dec 13, 2018
@craigbarnes @chozekun
Remove special handling for <isindex> tag
289bb5c 
It was removed from the whatwg HTML spec more than 2 years ago and has
since been removed from most major browsers and also the html5lib tests.

See also:

* whatwg/html#1095
* html5lib/html5lib-tests#74

This commit makes 5 additional tree-construction tests pass:

    Ran 1646 tests in 0.15s
    Passed: 1646
    Failed: 0
    Skipped: 51
chozekun pushed a commit to chozekun/gumbo-parser that referenced this pull request Dec 16, 2018
@craigbarnes @chozekun
Remove special handling for <isindex> tag
0265628 
It was removed from the whatwg HTML spec more than 2 years ago and has
since been removed from most major browsers and also the html5lib tests.

See also:

* whatwg/html#1095
* html5lib/html5lib-tests#74

This commit makes 5 additional tree-construction tests pass:

    Ran 1646 tests in 0.15s
    Passed: 1646
    Failed: 0
    Skipped: 51
chozekun pushed a commit to chozekun/gumbo-parser that referenced this pull request Dec 16, 2018
@craigbarnes @chozekun
Remove special handling for <isindex> tag
e0bc80e 
It was removed from the whatwg HTML spec more than 2 years ago and has
since been removed from most major browsers and also the html5lib tests.

See also:

* whatwg/html#1095
* html5lib/html5lib-tests#74

This commit makes 5 additional tree-construction tests pass:

    Ran 1646 tests in 0.15s
    Passed: 1646
    Failed: 0
    Skipped: 51
@foolip foolip mentioned this pull request Nov 4, 2020
Merged
5 tasks
flavorjones pushed a commit to sparklemotion/nokogiri that referenced this pull request Apr 7, 2021
@craigbarnes @stevecheckoway
Remove special handling for <isindex> tag
0c42557 
It was removed from the whatwg HTML spec more than 2 years ago and has
since been removed from most major browsers and also the html5lib tests.

See also:

* whatwg/html#1095
* html5lib/html5lib-tests#74

This commit makes 5 additional tree-construction tests pass:

    Ran 1646 tests in 0.15s
    Passed: 1646
    Failed: 0
    Skipped: 51
flavorjones pushed a commit to sparklemotion/nokogiri that referenced this pull request Apr 7, 2021
@craigbarnes @stevecheckoway
Remove special handling for <isindex> tag
7c36141 
It was removed from the whatwg HTML spec more than 2 years ago and has
since been removed from most major browsers and also the html5lib tests.

See also:

* whatwg/html#1095
* html5lib/html5lib-tests#74

This commit makes 5 additional tree-construction tests pass:

    Ran 1646 tests in 0.15s
    Passed: 1646
    Failed: 0
    Skipped: 51
@mohd-akram mohd-akram mentioned this pull request May 18, 2023
Closed
wooorm pushed a commit to wooorm/html-void-elements that referenced this pull request May 19, 2023
@mohd-akram
Remove elements that are no longer void
7b5cb87 
Some obsolete elements got their void status takes away,
meaning `document.createElement(x).outerHTML` generates an opening and
closing tag, so this fix matches that behavior.

Related-to: whatwg/html#1095
Related-to: whatwg/html#2319

Closes GH-6.
Closes GH-7.
@anthonyvdotbe anthonyvdotbe mentioned this pull request Feb 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
removal/deprecation Removing or deprecating a feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annevk @domenic