Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demix SVGFilterPrimitiveStandardAttributes #10646

Merged
merged 1 commit into from
May 28, 2021

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented May 27, 2021

Data from (confirmed by) mdn-bcd-collector:

  • Chrome ≤15
  • Edge 12 / 79
  • Firefox ≤4
  • Firefox Android ≤86
  • IE 10
  • Opera ≤12.1 / 15
  • Safari 6
  • Safari iOS ≤10.3

Chrome ≤15 is assumed to be 5 in most cases where it was 5 here:
#7197

Firefox ≤4 is assumed to be 3 based on:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/3

Mirrored data:

  • Firefox Android 4
  • Opera Android ≤12.1 / 14
  • Safari iOS 6
  • Samsung Internet 1.0
  • WebView Android ≤37

Most of the data is very regular. Notable exceptions:

Data from (confirmed by) mdn-bcd-collector:
- Chrome ≤15
- Edge 12 / 79
- Firefox ≤4
- Firefox Android ≤86
- IE 10
- Opera ≤12.1 / 15
- Safari 6
- Safari iOS ≤10.3

Chrome ≤15 is assumed to be 5 in most cases where it was 5 here:
mdn#7197

Firefox ≤4 is assumed to be 3 based on:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/3

Mirrored data:
- Firefox Android 4
- Opera Android ≤12.1 / 14
- Safari iOS 6
- Samsung Internet 1.0
- WebView Android ≤37

Most of the data is very regular. Notable exceptions:
- SVGFEConvolveMatrixElement entries are assumed to have shipped in
  Chrome 6, like api.SVGFEConvolveMatrixElement and its subfeatures.
- SVGFEDropShadowElement was shipped in Chrome 13 / Firefox 30, and
  seemingly never supported in IE, EdgeHTML or Presto.
- In Firefox, something strange happened with 3 of the interfaces. In
  Firefox 21, almost all subfeatures of these tests pass:
  http://mdn-bcd-collector.appspot.com/tests/api/SVGFEComponentTransferElement
  http://mdn-bcd-collector.appspot.com/tests/api/SVGFEFloodElement
  http://mdn-bcd-collector.appspot.com/tests/api/SVGFEGaussianBlurElement (except edgeMode)

  In Firefox 22, the height/result/width/x/y fail. They're back in Firefox
  29/35. This looks like a mishap, but is captured in the data anyway.
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label May 27, 2021
@foolip foolip requested a review from Elchi3 May 27, 2021 09:30
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is quite impressive. Maybe the largest PR that submits complete real data? (no true or null in here, so great!)

I trust the BCD collector and the mirroring makes sense to me, too. Thanks for also getting into some of the exceptions.

The only change request I have is to please add mdn_urls to the main interfaces at least. The sub features will all be 404, so let's not add these, but I think all the interfaces are present on MDN.

@foolip
Copy link
Collaborator Author

foolip commented May 28, 2021

Do you mean that I should add __compat entries with just mdn_url in them? Wouldn't that be in the merged data anyway?

@Elchi3
Copy link
Member

Elchi3 commented May 28, 2021

Oh wait, I'm stupid. The interfaces have their mdn_urls anyways already. This is mixins! Nevermind! 😊

@Elchi3 Elchi3 merged commit 176d4ed into mdn:main May 28, 2021
@foolip foolip deleted the demix-SVGFilterPrimitiveStandardAttributes branch May 28, 2021 14:17
@foolip
Copy link
Collaborator Author

foolip commented May 28, 2021

Thanks for review @Elchi3!

ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Jun 2, 2021
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Jun 2, 2021
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Jun 3, 2021
ddbeck added a commit that referenced this pull request Jun 4, 2021
* Bump version to v3.3.6
* Add release note for #10646
* Add release note for #10581
* Add release note for #10685
* Add release note for #10691
* Add release note for #6957
* Add release note for #10721
* Add release note for #10695
* Add release note for #9821
* Add release note for #10681
* Add release note for #10725
* Add stats
* Add release date
* Wordsmith
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants