-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demix LinkStyle mixin #10724
Merged
Merged
Demix LinkStyle mixin #10724
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0a2afb7
Demix LinkStyle mixin
queengooborg 4c22e16
Update api/_mixins/LinkStyle__HTMLLinkElement.json
queengooborg 94836b3
Apply suggestions from code review
queengooborg 05f1fc6
Merge branch 'main' into api/LinkStyle/demix
queengooborg 0108176
Remove sheet from api/HTMLStyleElement.json
queengooborg 02f0ea5
Correct Safari data
queengooborg cfaeb3f
SVGStyleElement also inherits LinkStyle
queengooborg d30dc20
Fix API name
queengooborg 3a9662a
Fix WebView Android version
queengooborg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| { | ||
| "api": { | ||
| "HTMLLinkElement": { | ||
| "sheet": { | ||
| "__compat": { | ||
| "mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLLinkElement/sheet", | ||
| "spec_url": "https://drafts.csswg.org/cssom/#dom-linkstyle-sheet", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": "1" | ||
| }, | ||
| "chrome_android": { | ||
| "version_added": "18" | ||
| }, | ||
| "edge": { | ||
| "version_added": "12" | ||
| }, | ||
| "firefox": { | ||
| "version_added": "1" | ||
| }, | ||
| "firefox_android": { | ||
| "version_added": "4" | ||
| }, | ||
| "ie": { | ||
| "version_added": "9" | ||
| }, | ||
| "opera": { | ||
| "version_added": "15" | ||
queengooborg marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }, | ||
| "opera_android": { | ||
| "version_added": "14" | ||
| }, | ||
| "safari": { | ||
| "version_added": "1" | ||
| }, | ||
| "safari_ios": { | ||
| "version_added": "1" | ||
| }, | ||
| "samsunginternet_android": { | ||
| "version_added": "1.0" | ||
| }, | ||
| "webview_android": { | ||
| "version_added": "1" | ||
| } | ||
| }, | ||
| "status": { | ||
| "experimental": false, | ||
| "standard_track": true, | ||
| "deprecated": false | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| { | ||
| "api": { | ||
| "HTMLStyleElement": { | ||
| "sheet": { | ||
| "__compat": { | ||
| "mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLStyleElement/sheet", | ||
| "spec_url": "https://drafts.csswg.org/cssom/#dom-linkstyle-sheet", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": "1" | ||
| }, | ||
| "chrome_android": { | ||
| "version_added": "18" | ||
| }, | ||
| "edge": { | ||
| "version_added": "12" | ||
| }, | ||
| "firefox": { | ||
| "version_added": "1" | ||
| }, | ||
| "firefox_android": { | ||
| "version_added": "4" | ||
| }, | ||
| "ie": { | ||
| "version_added": "9" | ||
| }, | ||
| "opera": { | ||
| "version_added": "≤12.1" | ||
| }, | ||
| "opera_android": { | ||
| "version_added": "≤12.1" | ||
| }, | ||
| "safari": { | ||
| "version_added": "1" | ||
| }, | ||
| "safari_ios": { | ||
| "version_added": "1" | ||
| }, | ||
| "samsunginternet_android": { | ||
| "version_added": "1.0" | ||
| }, | ||
| "webview_android": { | ||
| "version_added": "1" | ||
| } | ||
| }, | ||
| "status": { | ||
| "experimental": false, | ||
| "standard_track": true, | ||
| "deprecated": false | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| { | ||
| "api": { | ||
| "ProcessingInstruction": { | ||
| "sheet": { | ||
| "__compat": { | ||
| "mdn_url": "https://developer.mozilla.org/docs/Web/API/ProcessingInstruction/sheet", | ||
| "spec_url": "https://drafts.csswg.org/cssom/#dom-linkstyle-sheet", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": "1" | ||
| }, | ||
| "chrome_android": { | ||
| "version_added": "18" | ||
| }, | ||
| "edge": { | ||
| "version_added": "12" | ||
| }, | ||
| "firefox": { | ||
| "version_added": "1" | ||
| }, | ||
| "firefox_android": { | ||
| "version_added": "4" | ||
| }, | ||
| "ie": { | ||
| "version_added": "9" | ||
| }, | ||
| "opera": { | ||
| "version_added": "15" | ||
| }, | ||
| "opera_android": { | ||
| "version_added": "14" | ||
| }, | ||
| "safari": { | ||
| "version_added": "1" | ||
| }, | ||
| "safari_ios": { | ||
| "version_added": "1" | ||
| }, | ||
| "samsunginternet_android": { | ||
| "version_added": "1.0" | ||
| }, | ||
| "webview_android": { | ||
| "version_added": "1" | ||
| } | ||
| }, | ||
| "status": { | ||
| "experimental": false, | ||
| "standard_track": true, | ||
| "deprecated": false | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| { | ||
| "api": { | ||
| "SVGStyleElement": { | ||
| "sheet": { | ||
| "__compat": { | ||
| "mdn_url": "https://developer.mozilla.org/docs/Web/API/SVGStyleElement/sheet", | ||
| "spec_url": "https://drafts.csswg.org/cssom/#dom-linkstyle-sheet", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": "1" | ||
| }, | ||
| "chrome_android": { | ||
| "version_added": "18" | ||
| }, | ||
| "edge": { | ||
| "version_added": "12" | ||
| }, | ||
| "firefox": { | ||
| "version_added": "1.5" | ||
| }, | ||
| "firefox_android": { | ||
| "version_added": "4" | ||
| }, | ||
| "ie": { | ||
| "version_added": "9" | ||
| }, | ||
| "opera": { | ||
| "version_added": "≤12.1" | ||
| }, | ||
| "opera_android": { | ||
| "version_added": "≤12.1" | ||
| }, | ||
| "safari": { | ||
| "version_added": "3" | ||
| }, | ||
| "safari_ios": { | ||
| "version_added": "1" | ||
| }, | ||
| "samsunginternet_android": { | ||
| "version_added": "1.0" | ||
| }, | ||
| "webview_android": { | ||
| "version_added": "1" | ||
queengooborg marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| }, | ||
| "status": { | ||
| "experimental": false, | ||
| "standard_track": true, | ||
| "deprecated": false | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't exist, at least not yet. Will you also prepare a PR for https://github.com/mdn/content that removes all references to
LinkStyle, similar to mdn/content#5579? https://github.com/mdn/content#moving-one-or-more-documents might come in handy if so.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't contributed to the content repository yet, but I'd be happy to write a PR to go along with this one!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently there's no page for
LinkStyle.sheet, so I can't move/copy it. Additionally, there aren't any pages for thesheetproperty on any of the inheriting APIs. Not really sure what to do on the content repo, would love some assistance!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the main task here is to remove mentions of
LinkStyle.sheet. There's no page, but there are references to it. Searching that string should mostly turn up variations on{{domxref("LinkStyle.sheet")}}—there's just a few of them, but you'll need to read it in context to figure out what exactly to cut out (e.g., a<dt>-<dd>pair).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've sent mdn/content#5669 to accompany this PR!