Demix Body to Request and Response #10958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data from mdn-bcd-collector was used to confirm data for these versions: - Chrome 42 (most entries) - Chrome 43 (Response.body) - Chrome 60 (formData attributes) - Edge 14 (most entries) - Edge 79 (formData attributes) - Firefox 39 (most entries) - Firefox 65 (Response.body) - Safari 10.1 (most entries, including always-rejecting Response.formData) - Safari 11.1 (Request.body + always-rejecting Request.formData) The fixed formData attributes in Safari 14.1 / iOS 14.3 is based on: mdn#6620 Anything else was mirrored, including all mobile browser data. IE was not tested at all. Notable differences to the original data: - Request.body is not shipped in Chrome/Firefox: https://crbug.com/688906 https://bugzil.la/1387483 - Response.body was shipped in Chrome 43: https://bugs.chromium.org/p/chromium/issues/detail?id=240603#c40 - Edge ≤18 versions all replaced - A bunch of false values changed to real version This also changes the experimental status to false, since this has all been shipped basically everywhere now. Closes mdn#6620.
github-actions
bot
added
the
data:api
|
This was a lot of work and if anyone would like to work on the MDN change, I would be very grateful. I have still have one point of doubt, and that's the @youennf you came up in my WebKit source digging. Do you know of simple test cases for |
queengooborg
added
needs content update
Elchi3
approved these changes
Jun 29, 2021
There was a problem hiding this comment.
LGTM but should be merged in the same week as mdn/content#6455
|
The content changes landed, so merging this as well (otherwise we will have no compat table on the Request and Response pages) |
Elchi3
removed
the
needs content update
ddbeck
added a commit
to ddbeck/browser-compat-data
that referenced
this pull request
Jul 1, 2021
ddbeck
added a commit
that referenced
this pull request
Jul 1, 2021
* Bump version to v3.3.10 * Add release note for #10958 * Add release note for #11061 * Add release note for #11062 * Add release note for #11266 * Add release note for #11276 * Add release note for #11307 * Add release note for #11317 * Add release note for #11323 * Add release note for #11328 * Add release note for #11334 * Fix formatting * Set release date * Add stats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data from mdn-bcd-collector was used to confirm data for these versions:
The fixed formData attributes in Safari 14.1 / iOS 14.3 is based on:
#6620
Anything else was mirrored, including all mobile browser data. IE was
not tested at all.
Notable differences to the original data:
https://crbug.com/688906
https://bugzil.la/1387483
https://bugs.chromium.org/p/chromium/issues/detail?id=240603#c40
This also changes the experimental status to false, since this has all
been shipped basically everywhere now.
Closes #6620.