-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove entries for cloneNode() and importNode() deep parameters #11152
Conversation
Sorry if it seemed like I was suggesting something unorthodox. Here's what I was thinking: The " The " |
Capturing this in a note seems OK, but then I'd want to test all ancient browsers since most likely the note applies to more than Firefox. This would be a useless note to show to anyone today, would a range for just that note be acceptable, even without If it were up to me I'd just delete these entries. I'm very confident I could find invocations of APIs that work today that didn't work in ancient times that we don't have notes for, and shouldn't add notes for IMHO. This tension could also be resolved with a better mechanism for applying notes to a range of releases, and making sure that ancient notes are hidden on MDN. |
This one needs rebasing… |
These entries represent not the parameter itself, but whether it's optional and defaulting to false. Since that is the current spec'd behavior, these entries aren't irrelevant in the "removed for two years" sense, but if they were inverted to mean "defaults to true" they would be. This issue is already documented on both MDN pages: https://developer.mozilla.org/en-US/docs/Web/API/Node/cloneNode https://developer.mozilla.org/en-US/docs/Web/API/Document/importNode
d013201
to
cc231f0
Compare
I wrote http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=9482 to test the This could be represented as notes for Firefox, but it just seems like a net negative to represent this fact at all in BCD. Unless we have a way of hiding the information everywhere web developers might see it, either a note or a separate I'm now much more enthusiastic about deleting :) |
@foolip @sideshowbarker This got merged too quickly, unfortunately. If we're going to remove these features completely, then content changes are needed on both pages (which mention these historic oddities). |
* Bump version to v3.3.11 * Add release note for #11502 * Add release note for #11499 * Add release note for #11100 * Add release note for #11101 * Add release note for #11152 * Add release note for #11355 * Add release note for #11361 * Add release note for #11438 * Add release note for #11520 * Add release note for #11452 * Add release note for #11481 * Add second release note for #11481 * Add release note for #11500 * Add release note for #11524 * Add release note for #11413 * Add release note for #11414 * Add release date * Add stats * Fix formatting
@ddbeck I've sent mdn/content#6934 to also remove the notes from content. |
These entries represent not the parameter itself, but whether it's
optional and defaulting to false. Since that is the current spec'd
behavior, these entries aren't irrelevant in the "removed for two years"
sense, but if they were inverted to mean "defaults to true" they would
be.
This issue is already documented on both MDN pages:
https://developer.mozilla.org/en-US/docs/Web/API/Node/cloneNode
https://developer.mozilla.org/en-US/docs/Web/API/Document/importNode