Fix feature structure of HTMLCanvasElement API (and correct version numbers) #11234
Conversation
github-actions
bot
added
the
data:api 🐇
queengooborg
changed the title
There was a problem hiding this comment.
The structure looks great now! I have a lot of questions about the versions. This might turn into a giant rabbit hole, so if some of it can be turned into true or ranges to avoid digging too deep, I'd be OK with that. We'll come back to it :)
Or, we can excavate this rabbit hole and build a tidy little museum down there.
| "version_added": "41" | ||
| }, | ||
| "ie": { | ||
| "version_added": true |
There was a problem hiding this comment.
Was this really supported in IE?
There was a problem hiding this comment.
I'm unsure, this came from the original data. I'm actually not sure how to test this particular option.
There was a problem hiding this comment.
OK, let's leave it for now, it's true so we'll get back to it.
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
|
@vinyldarkscratch I notice in another review that |
|
@vinyldarkscratch there are still unresolved comments here, over to you :) |
| @@ -32,7 +32,7 @@ | |||
| "notes": "Opera Mini 5.0 and later has partial support." | |||
| }, | |||
| "safari": { | |||
| "version_added": "3" | |||
| "version_added": "2" | |||
There was a problem hiding this comment.
This is consistent with CanvasRenderingContext2D 👍
| "chrome": [ | ||
| { | ||
| "version_added": "81", | ||
| "notes": "ChromeOS and Windows" |
There was a problem hiding this comment.
Looks like https://bugs.chromium.org/p/chromium/issues/detail?id=945835 is the bug about enabling this.
|
A summary of the feature name changes that happened in this PR: Removed
Added
|
* Bump version to v4.0.0 * Add release note for #11234 * Bump known issues * Add release note for #11760 * Add release note for #11286 * Add release note for #9830 * Add release note for #10334 * Add v4.0.0 highlights to release notes * Add release note for #10753 * Revise description of `accepts_flags` hint * Add release note for #11961 * Add release note for #12059 * Add stats
This PR fixes up the names of the features within the
HTMLCanvasElementAPI. Many of the feature names did not conform to the documented guidelines, so this is an attempt to get them to conform properly. This also adds the2dcontext to our data, which was originally missing.As a part of the research of adding in the context and organizing the options, I've found some errors within our data. This PR fixes the data as well. (I would've separated it into another PR, but I thought it would be better to tackle it in one go.)