Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowercase console to match the name of the namespace and MDN #11534

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

foolip
Copy link
Contributor

@foolip foolip commented Jul 15, 2021

It has been lowercases on MDN:
mdn/content#6908

The BCD paths on MDN will also need updating.

All of the updated URLs were manually checked, and the one for exception
removed since it's a 404.

Fixes #7361.

@foolip foolip added the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jul 15, 2021
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jul 15, 2021
It has been lowercases on MDN:
mdn/content#6908

The BCD paths on MDN will also need updating.

All of the updated URLs were manually checked, and the one for exception
removed since it's a 404.

Fixes mdn#7361.
@foolip foolip force-pushed the lowercase-console branch from 2beb2c4 to 357aaf5 Compare July 15, 2021 09:19
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a reviewer, but this is ok. (And you removed the 404, good!)

@teoli2003
Copy link
Contributor

(Sorry, forgot about these)

@foolip
Copy link
Contributor Author

foolip commented Jul 15, 2021

@teoli2003 could I interest you in making the corresponding content change for this? I think there are a few remaining uppercase Console left that could be dealt with at the same time.

@teoli2003
Copy link
Contributor

teoli2003 commented Jul 15, 2021

@teoli2003 could I interest you in making the corresponding content change for this? I think there are a few remaining uppercase Console left that could be dealt with at the same time.

I did a recursive grep (rg) before but I just noticed it was on web/api, and that you are right, I see other occurrences (like in mozilla/ ).
Yes I will fix them.

@queengooborg queengooborg added needs-release-note 📰 and removed needs content update This PR needs a corresponding update to mdn/content to update the documentation labels Jul 16, 2021
Copy link
Contributor

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to be getting this one done! Since the content PR has been merged, I'd say we're ready to merge this!

@ctcpip
Copy link

ctcpip commented Jul 21, 2021

any idea why the spec/compat sections are now not working?

Screen Shot 2021-07-21 at 3 04 46 PM

@queengooborg
Copy link
Contributor

This PR didn't make the last BCD release. This will be fixed in the next release!

ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Jul 22, 2021
ddbeck added a commit that referenced this pull request Jul 22, 2021
* Bump version to v3.3.12

* Add release note for #11661

* Add release notes for
#11173 and #11175

* Add release note for #11534

* Add release note for #11544

* Add release note for #11551

* Add release note for #11555

* Add release note for #11556

* Add release note for #11557

* Add release note for #11633

* Add release note for #11636

* Add release note for #11637

* Add release note for #11530

* Add release stats and date

* Consolidate Safari for iOS version consolidation notes

* Format PR URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Console to console, remove corresponding field in global objects
5 participants