Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Firefox and Safari support for display-capture feature-policy #11700

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

lukewarlow
Copy link
Contributor

@lukewarlow lukewarlow commented Jul 23, 2021

Summary

This PR updates Firefox and Safari support for the display-capture feature policy. Also unmarks as experimental as it has at least 2 stable implementations.

Test results and supporting details

For Safari it's an educated guess based on the fact Safari implemented getDisplayMedia in Safari 13, and this commit which implements this feature was done in May 2019 which was before Safari 13 release.

I have also verified that it is at the very least implemented in Safari 14.1.

For the Firefox version, I tested with https://plastic-brief-carnation.glitch.me/ on browser stack and version 74 is when it worked as expected. I cannot find any mention of this in any Firefox release notes (I checked from version 67 onwards).

Tested on Firefox 92 and Safari 15 with https://demo.lukewarlow.uk/feature-policy/display-capture/ and can see that it doesn't support the header.

Firefox Android doesn't support get display media, and even when that's enabled (media.getdisplaymedia.enabled) it still doesn't actually work. So this feature policy can't be implemented in any meaningful way.

Related issues

Fixes #11554

Closes #12708

@github-actions github-actions bot added the data:http 🚠 Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP label Jul 23, 2021
@eladalon1983
Copy link

eladalon1983 commented Aug 26, 2021

Hello Luke,

I am still seeing incorrect data in MDN. Possibly the changes you've made have not gone live yet?


Screen Shot 2021-08-26 at 16 57 33

Screen Shot 2021-08-26 at 16 55 20

For Safari it's an educated guess

Safari supports it as an iframe tag, but not as an HTTP header. I believe @youennf from Apple might be able to provide more information.

For the Firefox version, I tested with https://plastic-brief-carnation.glitch.me/ on browser stack and version 74 is when it worked as expected.

@jan-ivar might be able to help nail down the precise version.

For the Chrome version it's based on https://bugs.chromium.org/p/chromium/issues/detail?id=1150788 and taken the commit in the chromium release finder I get version 89. Verified for 92+.

Chrome supports display-capture starting with m94. Here is the CL, and here is Chrome's release schedule. You'll note that this made it to the branch cut of m94.

Thanks,
Elad

@lukewarlow
Copy link
Contributor Author

It wont show yet because this MR hasn't been merged.

@lukewarlow
Copy link
Contributor Author

I'm not personally going to add Chrome 94 support until it shows up in https://www.chromestatus.com/features/schedule

Unless a reviewer thinks it makes sense to do.

Any clarifications on the exact Firefox version would be welcome.

With regards to Safari if it doesn't work in the header I'll update it to partial support.

@eladalon1983
Copy link

I've updated the chromestatus.com entry for display-capture to reflect it's shipping in m94.

@lukewarlow
Copy link
Contributor Author

Apologies didn't realise it was your changeset. 😆

@lukewarlow lukewarlow changed the title Update support for display-capture feature-policy Set Chrome 94 support for display-capture feature-policy Sep 21, 2021
@lukewarlow lukewarlow changed the title Set Chrome 94 support for display-capture feature-policy Update Firefox and Safari support for display-capture feature-policy Sep 21, 2021
@lukewarlow
Copy link
Contributor Author

Have moved the Chrome related portion of this to #12526. As that's known good data.

@jan-ivar
Copy link
Contributor

Safari supports it as an iframe tag, but not as an HTTP header.

Same in Firefox, even though Mozilla's position has softened a bit.

For the Firefox version, I tested with https://plastic-brief-carnation.glitch.me/ on browser stack and version 74 is when it worked as expected.

@jan-ivar might be able to help nail down the precise version.

This was enabled in 73.

@lukewarlow
Copy link
Contributor Author

lukewarlow commented Sep 22, 2021

Thank you, have updated the PR with a note about only working on an allow attribute on iframes. Have made a follow up issue to address the other feature policy values being wrong for Firefox. However, this was actually enabled in version 74. See https://bugzilla.mozilla.org/show_bug.cgi?id=1617219. It appears it was aimed for 73 but backed out.

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this looks like it's ready. Thank you! 🎉

@ddbeck ddbeck merged commit ee1e613 into mdn:main Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:http 🚠 Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP
Projects
None yet
4 participants