-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Firefox and Safari support for display-capture
feature-policy
#11700
Conversation
Hello Luke, I am still seeing incorrect data in MDN. Possibly the changes you've made have not gone live yet?
Safari supports it as an iframe tag, but not as an HTTP header. I believe @youennf from Apple might be able to provide more information.
@jan-ivar might be able to help nail down the precise version.
Chrome supports Thanks, |
It wont show yet because this MR hasn't been merged. |
I'm not personally going to add Chrome 94 support until it shows up in https://www.chromestatus.com/features/schedule Unless a reviewer thinks it makes sense to do. Any clarifications on the exact Firefox version would be welcome. With regards to Safari if it doesn't work in the header I'll update it to partial support. |
I've updated the chromestatus.com entry for |
Apologies didn't realise it was your changeset. 😆 |
71eea3d
to
b2b9aa4
Compare
display-capture
feature-policydisplay-capture
feature-policy
display-capture
feature-policydisplay-capture
feature-policy
b2b9aa4
to
281cf30
Compare
Have moved the Chrome related portion of this to #12526. As that's known good data. |
Same in Firefox, even though Mozilla's position has softened a bit.
This was enabled in 73. |
281cf30
to
6145b15
Compare
Thank you, have updated the PR with a note about only working on an allow attribute on iframes. Have made a follow up issue to address the other feature policy values being wrong for Firefox. However, this was actually enabled in version 74. See https://bugzilla.mozilla.org/show_bug.cgi?id=1617219. It appears it was aimed for 73 but backed out. |
a77bd96
to
3f22e1a
Compare
2df9f21
to
3523def
Compare
3523def
to
ad9f829
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this looks like it's ready. Thank you! 🎉
Summary
This PR updates Firefox and Safari support for the
display-capture
feature policy. Also unmarks as experimental as it has at least 2 stable implementations.Test results and supporting details
For Safari it's an educated guess based on the fact Safari implemented getDisplayMedia in Safari 13, and this commit which implements this feature was done in May 2019 which was before Safari 13 release.
I have also verified that it is at the very least implemented in Safari 14.1.
For the Firefox version, I tested with https://plastic-brief-carnation.glitch.me/ on browser stack and version 74 is when it worked as expected. I cannot find any mention of this in any Firefox release notes (I checked from version 67 onwards).
Tested on Firefox 92 and Safari 15 with https://demo.lukewarlow.uk/feature-policy/display-capture/ and can see that it doesn't support the header.
Firefox Android doesn't support get display media, and even when that's enabled (
media.getdisplaymedia.enabled
) it still doesn't actually work. So this feature policy can't be implemented in any meaningful way.Related issues
Fixes #11554
Closes #12708