Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set WebAuthn APIs as supported in Firefox Android 92 #12325

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

lukewarlow
Copy link
Contributor

Summary

This updates Firefox Android support for WebAuthn related APIs.

I've set them all as fully supported in Firefox 92. And left the preview entries as partial implementations.

I will file off an issue to investigate the extent of the implementation pre-92. I know that it was partially implemented as it passes basic feature detection but fails weirdly on https://webauthn.io

Test results and supporting details

Tested on https://webauthn.io

And https://www.mozilla.org/en-US/firefox/android/92.0/releasenotes/#:~:text=Added%20support%20for%20Web%20Authentication%20API

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Sep 9, 2021
@lukewarlow
Copy link
Contributor Author

https://developer.mozilla.org/en-US/docs/Web/API/Web_Authentication_API - Follow up issue about the notes

@ddbeck
Copy link
Collaborator

ddbeck commented Oct 19, 2021

Thanks for this PR, @lukewarlow! A question about this:

I will file off an issue to investigate the extent of the implementation pre-92.

Do I take this to mean that the values that have gone from false to "92" have some uncertainty to them? For instance, the values might truthfully be some version earlier than 92?

@lukewarlow
Copy link
Contributor Author

Do I take this to mean that the values that have gone from false to "92" have some uncertainty to them? For instance, the values might truthfully be some version earlier than 92?

I think it means that the partial_implementation might in fact be false and need removing in future, or the notes updating to give a fuller explanation.

I'm fairly confident that nothing of value to developers was implemented before 92. It's possible that interfaces were exposed but the functions not actually work.

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turns out those false to 92 entries will get resolved more cleanly with #12771. I'll go ahead and merge this one. Thank you, @lukewarlow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants