Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all browsers versions for WindowEventHandlers API #12413

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

queengooborg
Copy link
Collaborator

This PR adds real values for all browsers for the WindowEventHandlers API, based upon results from the mdn-bcd-collector project (v3.2.12).

Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/Window

This PR adds real values for all browsers for the `WindowEventHandlers` API, based upon results from the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v3.2.12).

Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/Window
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Sep 16, 2021
},
"firefox_android": {
"version_added": true
"version_added": "4"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support for the WindowEventHandlers doesn't really mean anything, but setting this to the earliest version of any of the subfeatures seems fine until WindowEventHandlers is removed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was my thought process, so that it doesn't impact our real values score until then!

@foolip
Copy link
Collaborator

foolip commented Sep 16, 2021

Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/Window

To cover everything that includes the mixin, there's also these tests:
https://mdn-bcd-collector.appspot.com/tests/api/HTMLBodyElement
https://mdn-bcd-collector.appspot.com/tests/api/HTMLFrameSetElement
https://mdn-bcd-collector.appspot.com/tests/api/SVGSVGElement

But I think just checking Window is fine for now, deciding what to do and untangling everything is the topic of #7545.

@foolip foolip merged commit 1dda3db into mdn:main Sep 16, 2021
@queengooborg queengooborg deleted the api/WindowEventHandlers/all branch September 16, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants