Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a guideline for when to use "preview" #12467

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Add a guideline for when to use "preview" #12467

merged 1 commit into from
Sep 17, 2021

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Sep 17, 2021

Summary

Adds a guideline to help contributors decide when to use "preview" values

Related issues

Fixes #12344

@ddbeck ddbeck requested a review from Elchi3 September 17, 2021 09:42
@github-actions github-actions bot added the docs ✍️ Issues or pull requests regarding the documentation of this project. label Sep 17, 2021
Elchi3
Elchi3 approved these changes Sep 17, 2021
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Daniel! This is what I had in mind with "preview" and I think it is also what we've discussed with other participants that shaped this feature.

@Elchi3 Elchi3 merged commit 5730465 into mdn:main Sep 17, 2021
@ddbeck ddbeck deleted the choosing-preview branch September 17, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
docs ✍️ Issues or pull requests regarding the documentation of this project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

What does "preview" mean for Firefox and Chrome?
2 participants
@ddbeck @Elchi3