Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated data for font-synthesis property #12931

Merged
merged 6 commits into from
Jan 4, 2022
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 58 additions & 0 deletions css/properties/font-synthesis-small-caps.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
{
"css": {
"properties": {
"font-synthesis-small-caps": {
"__compat": {
"spec_url": "https://drafts.csswg.org/css-fonts/#font-synthesis-small-caps",
"support": {
"chrome": {
"version_added": "97"
},
"chrome_android": {
"version_added": "97"
},
"edge": {
"version_added": false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other Chromium-based browsers are all but certain to ship this feature at the same time. It'd be nice to see that reflected in the data here.

You can find information on the map from Chrome (Blink) to other browsers in the browsers data: https://github.com/mdn/browser-compat-data/tree/main/browsers. For example, Edge (and WebView) would be 97 and Opera would be 83. If the browsers data doesn't map to 97 or later, then leave it as false (e.g., Opera Android). It's OK that some of the releases are in the future, provided it's consistent with the browsers data.

This would apply throughout the PR, for Edge, Opera, and WebView Android.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply and thank you for your comment, @ddbeck!
Following your suggestions, I have changed versions for other Chromium-based browsers as well.

},
"firefox": {
"version_added": false,
"notes": "<a href='https://bugzil.la/1724892'>bug 1724892</a>."
},
"firefox_android": {
"version_added": false,
"notes": "<a href='https://bugzil.la/1724892'>bug 1724892</a>."
},
"ie": {
"version_added": false
},
"opera": {
"version_added": false
},
"opera_android": {
"version_added": false
},
"safari": {
"version_added": false,
"notes": "<a href='https://webkit.org/b/232009'>bug 232009</a>."
},
"safari_ios": {
"version_added": false,
"notes": "<a href='https://webkit.org/b/232009'>bug 232009</a>."
},
"samsunginternet_android": {
"version_added": false
},
"webview_android": {
"version_added": false
}
},
"status": {
"experimental": true,
"standard_track": true,
"deprecated": false
}
}
}
}
}
}
58 changes: 58 additions & 0 deletions css/properties/font-synthesis-style.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
{
"css": {
"properties": {
"font-synthesis-style": {
"__compat": {
"spec_url": "https://drafts.csswg.org/css-fonts/#font-synthesis-style",
"support": {
"chrome": {
"version_added": "97"
},
"chrome_android": {
"version_added": "97"
},
"edge": {
"version_added": false
},
"firefox": {
"version_added": false,
"notes": "<a href='https://bugzil.la/1724892'>bug 1724892</a>."
},
"firefox_android": {
"version_added": false,
"notes": "<a href='https://bugzil.la/1724892'>bug 1724892</a>."
},
"ie": {
"version_added": false
},
"opera": {
"version_added": false
},
"opera_android": {
"version_added": false
},
"safari": {
"version_added": false,
"notes": "<a href='https://webkit.org/b/232009'>bug 232009</a>."
},
"safari_ios": {
"version_added": false,
"notes": "<a href='https://webkit.org/b/232009'>bug 232009</a>."
},
"samsunginternet_android": {
"version_added": false
},
"webview_android": {
"version_added": false
}
},
"status": {
"experimental": false,
tursunova marked this conversation as resolved.
Show resolved Hide resolved
"standard_track": true,
"deprecated": false
}
}
}
}
}
}
58 changes: 58 additions & 0 deletions css/properties/font-synthesis-weight.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
{
"css": {
"properties": {
"font-synthesis-weight": {
"__compat": {
"spec_url": "https://drafts.csswg.org/css-fonts/#font-synthesis-weight",
"support": {
"chrome": {
"version_added": "97"
},
"chrome_android": {
"version_added": "97"
},
"edge": {
"version_added": false
},
"firefox": {
"version_added": false,
"notes": "<a href='https://bugzil.la/1724892'>bug 1724892</a>."
},
"firefox_android": {
"version_added": false,
"notes": "<a href='https://bugzil.la/1724892'>bug 1724892</a>."
},
"ie": {
"version_added": false
},
"opera": {
"version_added": false
},
"opera_android": {
"version_added": false
},
"safari": {
"version_added": false,
"notes": "<a href='https://webkit.org/b/232009'>bug 232009</a>."
},
"safari_ios": {
"version_added": false,
"notes": "<a href='https://webkit.org/b/232009'>bug 232009</a>."
},
"samsunginternet_android": {
"version_added": false
},
"webview_android": {
"version_added": false
}
},
"status": {
"experimental": false,
tursunova marked this conversation as resolved.
Show resolved Hide resolved
"standard_track": true,
"deprecated": false
}
}
}
}
}
}
8 changes: 4 additions & 4 deletions css/properties/font-synthesis.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
"spec_url": "https://drafts.csswg.org/css-fonts/#font-synthesis",
"support": {
"chrome": {
"version_added": false
"version_added": "97"
},
"chrome_android": {
"version_added": false
"version_added": "97"
},
"edge": {
"version_added": false
Expand Down Expand Up @@ -54,10 +54,10 @@
"description": "<code>small-caps</code>",
"support": {
"chrome": {
"version_added": false
"version_added": "97"
},
"chrome_android": {
"version_added": false
"version_added": "97"
},
"edge": {
"version_added": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version_added": false
"version_added": false

I think this can be added and updated to 97 as well once Edge gets to shipping that release, but that could be a separate CL.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe separate one, so this one doesn't depend on Edge 97 release date, which according to this is a couple weeks later than Chrome 97 release?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, makes sense.

Expand Down