Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove api.isSecureContext.considers_window_opener #13127

Merged

Conversation

queengooborg
Copy link
Contributor

This PR removes api.isSecureContext.considers_window_opener from BCD. This feature is marked as standard and experimental, but looking through the spec I cannot find any mention of an opener or anything relevant for this property. It's possible this was added to a draft version of the spec, added in Firefox, but then removed from the spec.

Additionally, there is no documentation on on the MDN page that discusses what this feature means exactly.

This PR removes `api.isSecureContext.considers_window_opener` from BCD.  This feature is marked as standard and experimental, but looking through the spec I cannot find any mention of an `opener` or anything relevant for this property.  It's possible this was added to a draft version of the spec, added in Firefox, but then removed from the spec.

Additionally, there is no documentation on on the MDN page that discusses what this feature means exactly.
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 26, 2021
@foolip
Copy link
Contributor

foolip commented Oct 29, 2021

@queengooborg can you find the PR that added this and request review from those involved?

@queengooborg
Copy link
Contributor Author

This feature came from the initial wiki migration, it looks like: https://github.com/mdn/browser-compat-data/pull/2044/files#diff-0af204b45434f45eda843193144af2351b8c5ff07903ac29ba5aae047195ba25R925

Considering that only the Firefox data was filled out for this subfeature, I'm pretty certain that this was something that was changed in Firefox and then added to the compat tables. Since this isn't a spec feature nor something any other browsers have, I think that we should remove it. We could potentially create a note describing the behavior, but I feel it's not worthwhile anyways.

@foolip
Copy link
Contributor

foolip commented Nov 23, 2021

Thanks for checking! I agree this can be removed.

@foolip foolip merged commit 81cfc48 into mdn:main Nov 23, 2021
@queengooborg queengooborg deleted the api/isSecureContext/considers_window_opener branch November 23, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants