Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt out of GitHub fetch in push artifact workflow #13801

Merged
merged 2 commits into from
Nov 30, 2021

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Nov 29, 2021

Summary

This adds an option to diff-features to opt out of getting artifacts from GitHub and does so in the workflow that generates the artifacts that you would fetch from GitHub.

Test results and supporting details

This reduces the noise in the output for the workflow. Because we run this workflow to generate the thing that this would fetch, it won't ever fetch the artifact. The added flag skips ahead to a direct diff.

Related issues

The sequel to #13695 and #13720.

This reduces the noise in the output for the workflow. Because we run
this workflow to generate the thing that this would fetch, it won't ever
fetch the artifact. The added flag skips ahead to a direct diff.
@ddbeck ddbeck requested a review from Elchi3 November 29, 2021 14:42
@github-actions github-actions bot added infra Infrastructure issues (npm, GitHub Actions, releases) of this project scripts Issues or pull requests regarding the scripts in scripts/. labels Nov 29, 2021
@Elchi3 Elchi3 merged commit 33da2dd into mdn:main Nov 30, 2021
@ddbeck ddbeck deleted the opt-out-github-fetch branch November 30, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infrastructure issues (npm, GitHub Actions, releases) of this project scripts Issues or pull requests regarding the scripts in scripts/.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants