Documenting the titlebar-area-* env variables #14035
+496
−0
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -112,6 +112,109 @@ | |
| "standard_track": true, | ||
| "deprecated": false | ||
| } | ||
| }, | ||
| "safe-area-inset": { | ||
| "__compat": { | ||
| "mdn_url": "https://developer.mozilla.org/docs/Web/CSS/env()", | ||
| "spec_url": "https://drafts.csswg.org/css-env/#safe-area-insets", | ||
| "description": "Safe area inset variables <code>safe-area-inset-top</code>, <code>safe-area-inset-right</code>, <code>safe-area-inset-bottom</code>, and <code>safe-area-inset-left</code>", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": "69" | ||
| }, | ||
| "chrome_android": { | ||
| "version_added": "69" | ||
| }, | ||
| "edge": { | ||
| "version_added": "79" | ||
| }, | ||
| "firefox": { | ||
| "version_added": "65" | ||
| }, | ||
| "firefox_android": { | ||
| "version_added": "65" | ||
| }, | ||
| "ie": { | ||
| "version_added": false | ||
| }, | ||
| "opera": { | ||
| "version_added": "56" | ||
| }, | ||
| "opera_android": { | ||
| "version_added": "48" | ||
| }, | ||
| "safari": { | ||
| "version_added": "11" | ||
| }, | ||
| "safari_ios": { | ||
| "version_added": "11" | ||
| }, | ||
| "samsunginternet_android": { | ||
| "version_added": "10.0" | ||
| }, | ||
| "webview_android": { | ||
| "version_added": "69" | ||
| } | ||
| }, | ||
| "status": { | ||
| "experimental": false, | ||
| "standard_track": true, | ||
| "deprecated": false | ||
| } | ||
| } | ||
| }, | ||
| "titlebar-area": { | ||
|
There was a problem hiding this comment. Some goes for these keywords |
||
| "__compat": { | ||
| "mdn_url": "https://developer.mozilla.org/docs/Web/CSS/env()", | ||
| "spec_url": "https://wicg.github.io/window-controls-overlay/#title-bar-area-env-variables", | ||
| "description": "Window Controls Overlay variables <code>titlebar-area-x</code>, <code>titlebar-area-y</code>, <code>titlebar-area-width</code>, and <code>titlebar-area-height</code>", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": "92", | ||
| "notes": "Linux support was added in 93." | ||
|
There was a problem hiding this comment. OS limitations like this require
Also, typically, notes are written in the present tense (as if from the perspective of the version(s) to which it applies). Something like this: "Before version 93, Linux is unsupported." There was a problem hiding this comment. Awesome. Thanks for the tip. Now I know how to do this properly. |
||
| }, | ||
| "chrome_android": { | ||
| "version_added": "92", | ||
| "notes": "Linux support was added in 93." | ||
| }, | ||
| "edge": { | ||
| "version_added": "92", | ||
| "notes": "Linux support was added in 93." | ||
| }, | ||
| "firefox": { | ||
| "version_added": false | ||
| }, | ||
| "firefox_android": { | ||
| "version_added": false | ||
| }, | ||
| "ie": { | ||
| "version_added": false | ||
| }, | ||
| "opera": { | ||
| "version_added": "78" | ||
| }, | ||
| "opera_android": { | ||
| "version_added": "65" | ||
| }, | ||
| "safari": { | ||
| "version_added": false | ||
| }, | ||
| "safari_ios": { | ||
| "version_added": false | ||
| }, | ||
| "samsunginternet_android": { | ||
| "version_added": false | ||
| }, | ||
| "webview_android": { | ||
| "version_added": false | ||
| } | ||
| }, | ||
| "status": { | ||
| "experimental": true, | ||
| "standard_track": true, | ||
| "deprecated": false | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "var": { | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind expanding these to separate features for each keyword? (See my other comments first, however, to simplify the copy-and-paste.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see, so that they each show up individually in the compat tables. Makes sense.