Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt AudioScheduledSourceNode ended event to new structure #14963

Merged

Conversation

queengooborg
Copy link
Collaborator

This PR adapts the ended event of the AudioScheduledSourceNode API to the new guidelines. Part of work for #14578.

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Feb 14, 2022
@Elchi3 Elchi3 added the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Feb 14, 2022
@Elchi3
Copy link
Member

Elchi3 commented Feb 14, 2022

This PR is fine.

However, the content work is not complete. https://developer.mozilla.org/docs/Web/API/AudioScheduledSourceNode/onended still exists and should redirect to https://developer.mozilla.org/docs/Web/API/AudioScheduledSourceNode/ended_event.

@queengooborg
Copy link
Collaborator Author

The redirect has actually already been performed!

@Elchi3 Elchi3 removed the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Feb 16, 2022
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I see it now :)

@Elchi3 Elchi3 merged commit 26cb9cf into mdn:main Feb 16, 2022
@queengooborg queengooborg deleted the api/AudioScheduledSourceNode/ended_event branch February 16, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants