Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix structure of dump() data #15020

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Fix structure of dump() data #15020

merged 1 commit into from
Feb 17, 2022

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Feb 17, 2022

Summary

Show unflagged existence of dump() (i.e., that "dump" in window is true), which is implied by the existing notes.

Related issues

Post-merge suggestions for #15014 by @wbamberg.

@ddbeck ddbeck requested a review from Elchi3 February 17, 2022 13:26
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Feb 17, 2022
Post-merge suggestions for mdn#15014
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Daniel, this makes sense to me!

(and if we ever lint for irrelevant features behind a flag only, this will not fall into that category since it is exposed even if only partially working)

@Elchi3 Elchi3 merged commit 6e0e500 into mdn:main Feb 17, 2022
@ddbeck ddbeck deleted the dump-partial branch February 17, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants