Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt api.Document.onreadystatechange to new events structure #15085

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

queengooborg
Copy link
Collaborator

This PR adapts the readystatechange event of the Document API to conform to the new events structure.

This PR adapts the readystatechange event of the Document API to conform to the new events structure.
@queengooborg queengooborg added the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Feb 22, 2022
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Feb 22, 2022
@ddbeck
Copy link
Collaborator

ddbeck commented Feb 22, 2022

As far as I can tell, there's no corresponding api.Document.readystatechange_event. Perhaps you didn't push all the changes to this PR?

@queengooborg
Copy link
Collaborator Author

There is -- no modifications were made to it because the data between the event handler and the event match!

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the readystatechange_event, so this seems fine to me 👍

@Elchi3 Elchi3 removed the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Feb 22, 2022
@Elchi3 Elchi3 merged commit 1416e96 into mdn:main Feb 22, 2022
@queengooborg queengooborg deleted the api/Document/readystatechange/events branch February 22, 2022 14:50
@ddbeck
Copy link
Collaborator

ddbeck commented Feb 24, 2022

Ah, for some reason GitHub's code search never turned up that feature (I have no idea why). Grepping turned up the feature. Sorry about that. (Though, for reviewer's convenience, it'd be nice to link to the related features, when they're not part of the diff.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants