Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove api.HTMLBodyElement.orientationchange event #15156

Merged

Conversation

queengooborg
Copy link
Collaborator

This PR adapts the orientationchange event of the HTMLBodyElement API to conform to the new events structure.

Note: there are no MDN pages associated with these events, so there will be no corresponding content PR. Any broken MDN URLs in BCD have been removed.

This PR adapts the orientationchange event of the HTMLBodyElement API to conform to the new events structure.

Note: there are no MDN pages associated with these events, so there will be no corresponding content PR. Any broken MDN URLs in BCD have been removed.
@queengooborg queengooborg added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Feb 28, 2022
@foolip
Copy link
Collaborator

foolip commented Mar 4, 2022

Per https://compat.spec.whatwg.org/#windoworientation-interface this event should be fired the Window object, but Safari also fires it at HTMLBodyElement.

Some testing to check if an event handler added with document.body.addEventListener('orientationchange', callback) will ever be called would be good.

If it's only Safari that ever fires the event at HTMLBodyElement, then the data should be updated and "standard_track" set to false. Or maybe we just remove this entry, I'm not sure it's useful.

@Elchi3
Copy link
Member

Elchi3 commented Mar 14, 2022

I think we should remove this entry. If we want, we can add a note to api.window.orientationchange_event for Safari and say that there is non-standard behavior implemented that makes the event also fire at HTMLBodyElement.

@Elchi3
Copy link
Member

Elchi3 commented Mar 28, 2022

@queengooborg do you want to remove this entry in this PR?

@queengooborg queengooborg changed the title Adapt api.HTMLBodyElement.onorientationchange to new events structure Remove api.HTMLBodyElement.orientationchange event Mar 29, 2022
@foolip foolip merged commit fbdf3fb into mdn:main Mar 29, 2022
@queengooborg queengooborg deleted the api/HTMLBodyElement/orientationchange/events branch March 29, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants