Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt api.MediaKeySession.onmessage to new events structure #15167

Merged
merged 3 commits into from
Mar 29, 2022

Conversation

queengooborg
Copy link
Collaborator

This PR adapts the message event of the MediaKeySession API to conform to the new events structure.

This PR adapts the message event of the MediaKeySession API to conform to the new events structure.
@queengooborg queengooborg added data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation labels Feb 28, 2022
@queengooborg queengooborg removed the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Mar 7, 2022
Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://source.chromium.org/chromium/chromium/src/+/6e3647df59a9b8a2c77d49ce5681e2a5b3ab7d17 shows that the event handler attributes were added after the events themselves. Can you add partial_implementation ranges?

@Elchi3
Copy link
Member

Elchi3 commented Mar 28, 2022

I think the following is needed here:

"chrome": [
  {
    "version_added": "55"
  },
  {
    "version_added": "42",
    "version_removed": "55",
    "partial_implementation": true,
    "notes": "The <code>onkeystatuseschange</code> event handler property is not supported."
  }
],

And

"chrome": [
  {
    "version_added": "55"
  },
  {
    "version_added": "42",
    "version_removed": "55",
    "partial_implementation": true,
    "notes": "The <code>onmessage</code> event handler property is not supported."
  }
],

(same structure [with different versions] for other chromium based browsers)

},
"chrome": [
{
"version_added": "55"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@foolip foolip merged commit 1399dc3 into mdn:main Mar 29, 2022
@queengooborg queengooborg deleted the api/MediaKeySession/message/events branch March 29, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants