Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt NetworkInformation API to new events structure #15177

Merged
merged 2 commits into from
Mar 18, 2022

Conversation

queengooborg
Copy link
Collaborator

This PR adapts the NetworkInformation API to conform to the new events structure.

This PR adapts the NetworkInformation API to conform to the new events structure.
@queengooborg queengooborg added data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation labels Feb 28, 2022
@queengooborg queengooborg removed the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Mar 16, 2022
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks to me as if typechange/ontypechange isn't a thing anymore.
Can you confirm and remove?

@queengooborg
Copy link
Collaborator Author

Running https://mdn-bcd-collector.appspot.com/tests/api/NetworkInformation/ontypechange in BrowserStack on Chrome Android 96, it appears that it's still implemented. However, it's not standard track and there is a discussion open for Chrome's removal, see https://crbug.com/699892.

api/NetworkInformation.json Outdated Show resolved Hide resolved
@Elchi3
Copy link
Member

Elchi3 commented Mar 18, 2022

Running https://mdn-bcd-collector.appspot.com/tests/api/NetworkInformation/ontypechange in BrowserStack on Chrome Android 96, it appears that it's still implemented. However, it's not standard track and there is a discussion open for Chrome's removal, see https://crbug.com/699892.

Ah interesting! Can you add that bug as a note? That way, people know that it is really a dead thing.

@Elchi3 Elchi3 merged commit 2c55f3b into mdn:main Mar 18, 2022
@queengooborg queengooborg deleted the api/NetworkInformation/events branch March 18, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants