Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt RTCPeerConnection API to new events structure #15192

Merged
merged 2 commits into from
Mar 18, 2022
Merged

Adapt RTCPeerConnection API to new events structure #15192

merged 2 commits into from
Mar 18, 2022

Conversation

queengooborg
Copy link
Collaborator

This PR adapts the RTCPeerConnection API to conform to the new events structure.

@queengooborg
Adapt RTCPeerConnection API to new events structure
da4bb5f 
This PR adapts the RTCPeerConnection API to conform to the new events structure.
@queengooborg queengooborg added data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation labels Feb 28, 2022
@queengooborg queengooborg mentioned this pull request Feb 28, 2022
Closed
@queengooborg queengooborg mentioned this pull request Mar 15, 2022
Merged
@queengooborg queengooborg removed the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Mar 16, 2022
Elchi3
Elchi3 requested changes Mar 17, 2022
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions here as I find some changes a bit odd.

api/RTCPeerConnection.json Outdated Show resolved Hide resolved
api/RTCPeerConnection.json Outdated Show resolved Hide resolved
api/RTCPeerConnection.json Outdated Show resolved Hide resolved
api/RTCPeerConnection.json Outdated Show resolved Hide resolved
api/RTCPeerConnection.json Outdated Show resolved Hide resolved
Elchi3
Elchi3 approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Elchi3 Elchi3 merged commit ed396f4 into mdn:main Mar 18, 2022
@queengooborg queengooborg deleted the api/RTCPeerConnection/events branch March 18, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @Elchi3